From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Oct 25 23:00:13 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6A199106568D for ; Sun, 25 Oct 2009 23:00:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 27DB08FC0A for ; Sun, 25 Oct 2009 23:00:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n9PN0C1b079946 for ; Sun, 25 Oct 2009 23:00:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n9PN0CFd079945; Sun, 25 Oct 2009 23:00:12 GMT (envelope-from gnats) Resent-Date: Sun, 25 Oct 2009 23:00:12 GMT Resent-Message-Id: <200910252300.n9PN0CFd079945@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Marcin Wisnicki Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 709FF1065676 for ; Sun, 25 Oct 2009 22:56:34 +0000 (UTC) (envelope-from mwisnicki+freebsd@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.152]) by mx1.freebsd.org (Postfix) with ESMTP id D01E98FC08 for ; Sun, 25 Oct 2009 22:56:33 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id d23so3984165fga.13 for ; Sun, 25 Oct 2009 15:56:32 -0700 (PDT) Received: by 10.86.234.9 with SMTP id g9mr41513fgh.39.1256511392129; Sun, 25 Oct 2009 15:56:32 -0700 (PDT) Received: from ghost.pnet.one.pl (static-78-8-147-77.ssp.dialog.net.pl [78.8.147.77]) by mx.google.com with ESMTPS id e11sm6764278fga.2.2009.10.25.15.56.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 25 Oct 2009 15:56:31 -0700 (PDT) Received: by ghost.pnet.one.pl (sSMTP sendmail emulation); Sun, 25 Oct 2009 23:56:29 +0100 Message-Id: <4ae4d79f.0b38560a.542d.4ad3@mx.google.com> Date: Sun, 25 Oct 2009 23:56:29 +0100 From: Marcin Wisnicki Sender: =?UTF-8?Q?Marcin_Wi=C5=9Bnicki?= To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: glarkin@FreeBSD.org Subject: ports/139975: [PATCH] graphics/GraphicsMagick13: missing support for png, jpeg and others X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Oct 2009 23:00:13 -0000 >Number: 139975 >Category: ports >Synopsis: [PATCH] graphics/GraphicsMagick13: missing support for png, jpeg and others >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Oct 25 23:00:12 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Marcin Wisnicki >Release: FreeBSD 7.2-STABLE i386 >Organization: >Environment: System: FreeBSD ghost.pnet.one.pl 7.2-STABLE FreeBSD 7.2-STABLE #3: Sat Oct 17 20:50:32 CEST 2009 >Description: When building with OPENMP (default) LDFLAGS variable in CONFIGURE_ENV is overriden. Unfortunately configure script will continue and automatically disable failing components. This results in a build that's missing all functionality provided by dependencies (libpng, lipjpeg, etc). Following patch adjusts LDFLAGS properly. For completeness some kind of modification to configure script is need so that it will always fail hard in case of errors. Alternate versions of port likely have similar problems. Port maintainer (glarkin@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99 >How-To-Repeat: >Fix: --- GraphicsMagick-1.3.7_1.patch begins here --- diff -ruN --exclude=CVS /usr/ports/graphics/GraphicsMagick13.orig/Makefile /usr/ports/graphics/GraphicsMagick13/Makefile --- /usr/ports/graphics/GraphicsMagick13.orig/Makefile 2009-10-18 04:08:17.000000000 +0200 +++ /usr/ports/graphics/GraphicsMagick13/Makefile 2009-10-25 17:38:16.000000000 +0100 @@ -7,6 +7,7 @@ PORTNAME= GraphicsMagick PORTVERSION= 1.3.7 +PORTREVISION= 1 CATEGORIES= graphics MASTER_SITES= SF \ ftp://ftp.graphicsmagick.org/pub/GraphicsMagick/1.3/ @@ -54,7 +55,8 @@ ALL_TARGET= -j`${SYSCTL} -n hw.ncpu` CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include" \ - LDFLAGS="-L${LOCALBASE}/lib" + LDFLAGS="${CONFIGURE_LDFLAGS}" +CONFIGURE_LDFLAGS=-L${LOCALBASE}/lib test check: cd ${WRKSRC} && ${SETENV} ${MAKE_ENV} ${MAKE} check @@ -79,6 +81,8 @@ .endif .endif +# XXX configure will continue even if optional components don't work + .if defined(WITH_FPX) LIB_DEPENDS+= fpx.[2-9]:${PORTSDIR}/graphics/libfpx CONFIGURE_ARGS+= --with-fpx @@ -98,7 +102,7 @@ IGNORE= does not support OpenMP on FreeBSD version ${OSVERSION} .endif -CONFIGURE_ENV+= LDFLAGS=${PTHREAD_LIBS} +CONFIGURE_LDFLAGS+= ${PTHREAD_LIBS} CONFIGURE_ARGS+= --with-threads --enable-openmp --disable-openmp-slow .else CONFIGURE_ARGS+= --without-threads --disable-openmp --- GraphicsMagick-1.3.7_1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: