From owner-svn-ports-all@FreeBSD.ORG Tue Dec 10 21:05:19 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 02FC2D3; Tue, 10 Dec 2013 21:05:19 +0000 (UTC) Received: from mail-pb0-x230.google.com (mail-pb0-x230.google.com [IPv6:2607:f8b0:400e:c01::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B564F1080; Tue, 10 Dec 2013 21:05:18 +0000 (UTC) Received: by mail-pb0-f48.google.com with SMTP id md12so8490536pbc.35 for ; Tue, 10 Dec 2013 13:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LPO59eVvrrBlKnTBnPrH6QqJCpYpSfziZ47aMktxOSQ=; b=T1Az7+p2lviRkjPIIx9guBGlIe6aiiE0KNVXDxu/GxwxR0IceL7pfO74X00rf7mYAO 96ExjqtNoWWp7lFXun/Nw17OyZRUlO7Y2xmXN2RdlEHm8mwrcReQcffDzgUeSulXvLBQ NY6IjCEPL+tK4WsgH50/Exd8+XCdG9t97QBNG6pO76KcQjzanXEf9Wk9ibTR2n9UsadU 5evDZA0c4o3BAdjDHaI1qSQPlkuJhKu8vJQvh91EeT42jBGxpIOmRaysCC1lEVKjni/f jym+OslH4tA0d3UlUOwhz+dHEnpkKJJGkhEImdjPzsOQ2axrYDfL3nWUWmy6zfJkPiaA cl4Q== MIME-Version: 1.0 X-Received: by 10.66.162.167 with SMTP id yb7mr30563582pab.16.1386709518335; Tue, 10 Dec 2013 13:05:18 -0800 (PST) Received: by 10.66.122.145 with HTTP; Tue, 10 Dec 2013 13:05:18 -0800 (PST) In-Reply-To: References: <201311291548.rATFm8g7098382@svn.freebsd.org> <529C7599.1050509@gmail.com> <52A7471E.6080109@gmail.com> Date: Tue, 10 Dec 2013 23:05:18 +0200 Message-ID: Subject: Re: svn commit: r335189 - in head/print/pdftk: . files From: Kozlov Sergey To: Gerald Pfeifer Content-Type: text/plain; charset=UTF-8 Cc: Mathieu Arnold , Greg Larkin , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Dec 2013 21:05:19 -0000 On Tue, Dec 10, 2013 at 7:48 PM, Gerald Pfeifer wrote: > On Tue, 10 Dec 2013, Kozlov Sergey wrote: >> Yes, that's correct. I think the right solution is to add a check if >> gcj is present and give an IGNORE with suggestion to rebuild gcc. > > Agreed. If gcj is not present despite that dependency, that's a > good idea. Would you like to propose a patch? > Sure, working on it. >>> LIB_DEPENDS= libgcj.so:${PORTSDIR}/lang/gcc${CSUFF} \ >>> libstdc++.so:${PORTSDIR}/lang/gcc${CSUFF} \ >>> libgcc_s.so:${PORTSDIR}/lang/gcc${CSUFF} >>> >>> If you insist on libgcj.so, I can accept that, but then let's drop >>> the other two least. This is definitely covered by USE_GCC=yes. >> USE_GCC doesn't add anything to RUN_DEPENDS. > > Sure it does: > > .if defined(_GCC_PORT_DEPENDS) > BUILD_DEPENDS+= ${_GCC_PORT_DEPENDS}:${PORTSDIR}/lang/${_GCC_PORT} > . if ${_USE_GCC} != 3.4 > RUN_DEPENDS+= ${_GCC_PORT_DEPENDS}:${PORTSDIR}/lang/${_GCC_PORT} > # Later GCC ports already depend on binutils; make sure whatever we > # build leverages this as well. > USE_BINUTILS= yes > . endif > .endif I've commented out the BUILD_DEPENDS and LIB_DEPENDS from the port, leaving only USE_GCC and built it root# make install ===> Installing for pdftk-2.02 ===> pdftk-2.02 depends on executable: gcc46 - found ===> Checking if print/pdftk already installed ===> Registering installation for pdftk-2.02 Installing pdftk-2.02... done Then I checked out portmaster output: root# portmaster -l ===>>> Root ports (No dependencies, not depended on) ===>>> dialog4ports-0.1.5_2 ===>>> gmake-3.82_1 ===>>> libtool-2.4.2_2 ===>>> pdftk-2.02 ... ===>>> Leaf ports (Have dependencies, not depended on) ===>>> bison-2.7.1,1 ===>>> gcc-4.6.4_1,1 ===>>> 2 leaf ports If gcc was installed as runtime dependency then pkg wouldn't let me delete it without forcing root# pkg delete binutils pkg: Error while trying to delete packages, dependencies that are still required: devel/binutils: lang/gcc46 root# pkg delete gcc Deinstallation has been requested for the following 1 packages: gcc-4.6.4_1,1 The deinstallation will free 567 MB Proceed with deinstalling packages [y/N]: I see the code in bsd.gcc.mk but it obviously doesn't work here What am I doing wrong? Best regards, Kozlov Sergey