From owner-freebsd-hackers@FreeBSD.ORG Wed Nov 10 07:30:39 2010 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D96A1065672; Wed, 10 Nov 2010 07:30:39 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout023.mac.com (asmtpout023.mac.com [17.148.16.98]) by mx1.freebsd.org (Postfix) with ESMTP id E86298FC2A; Wed, 10 Nov 2010 07:30:38 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=us-ascii Received: from sa-nc-common-155.static.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp023.mac.com (Sun Java(tm) System Messaging Server 6.3-8.01 (built Dec 16 2008; 32bit)) with ESMTPSA id <0LBN00AWYOPILN20@asmtp023.mac.com>; Tue, 09 Nov 2010 22:29:44 -0800 (PST) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=6.0.2-1004200000 definitions=main-1011090236 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.2.15,1.0.148,0.0.0000 definitions=2010-11-10_03:2010-11-10, 2010-11-09, 1970-01-01 signatures=0 From: Marcel Moolenaar In-reply-to: Date: Tue, 09 Nov 2010 22:29:41 -0800 Message-id: <478E6244-00B4-4D96-93FE-CBD546C27A6E@mac.com> References: To: Garrett Cooper X-Mailer: Apple Mail (2.1081) Cc: hackers@freebsd.org Subject: Re: [PATCH] Simplify uart_bus_pci_probe X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 07:30:39 -0000 On Nov 6, 2010, at 11:22 AM, Garrett Cooper wrote: > Some of the logic could have been simplified in the probe. The > proposed patch makes the detection process a tad bit more > straightforward. > Comments, review (and maybe a commit :P) are more than welcome :). The patch is logically wrong for non-ns8250 based UARTs. Leave the code as is. Thanks, -- Marcel Moolenaar xcllnt@mac.com