From owner-freebsd-bugs Thu Dec 25 03:37:35 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id DAA07879 for bugs-outgoing; Thu, 25 Dec 1997 03:37:35 -0800 (PST) (envelope-from owner-freebsd-bugs) Received: from ppp7265.on.bellglobal.com (ppp7265.on.bellglobal.com [206.172.249.233]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id DAA07874; Thu, 25 Dec 1997 03:37:29 -0800 (PST) (envelope-from hoek@FreeBSD.ORG) Received: from localhost (tim@localhost) by ppp7265.on.bellglobal.com (8.8.7/8.8.7) with SMTP id GAA24771; Thu, 25 Dec 1997 06:34:33 -0500 (EST) (envelope-from hoek@FreeBSD.ORG) X-Authentication-Warning: ppp7265.on.bellglobal.com: tim owned process doing -bs Date: Thu, 25 Dec 1997 06:34:32 -0500 (EST) From: Tim Vanderhoek X-Sender: tim@localhost Reply-To: Tim Vanderhoek To: Dmitrij Tejblum cc: Tim Vanderhoek , h-nokubi@nmit.mt.nec.co.jp, freebsd-bugs@FreeBSD.ORG Subject: Re: kern/2412 In-Reply-To: <199712251109.OAA01607@tejblum.dnttm.rssi.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Thu, 25 Dec 1997, Dmitrij Tejblum wrote: > I don't think it is correct answer. Did you looked to the 'Fix:' in this PR? > USER_LDT is a 'new style' option that go in opt_user_ldt.h. Files Well, I glanced over the 'Fix:'. Perhaps too briefly. :) ["Well, Wine works for me and my friends!"] > sys/i386/i386/machdep.c > sys/i386/i386/vm_machdep.c > sys/pc98/i386/machdep.c > contains #ifdef USER_LDT, but don't contain #include "opt_user_ldt.h". Rather than trying to guess wether the code is meant to be compiled or is just stale, I'll move it into feedback and just double-check that USER_LDT was supposed to have been configured. Is there someone specific responsible for the USER_LDT stuff who would be aware of potentially wrong code, or is it worth leaving the pr open just for that? -- tIM...HOEk OPTIMIZATION: the process of using many one-letter variables names hoping that the resultant code will run faster.