From owner-freebsd-bugs@FreeBSD.ORG  Wed Dec 24 01:24:19 2014
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 85134517
 for <freebsd-bugs@FreeBSD.org>; Wed, 24 Dec 2014 01:24:19 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6D5D51987
 for <freebsd-bugs@FreeBSD.org>; Wed, 24 Dec 2014 01:24:19 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBO1OJxi007945
 for <freebsd-bugs@FreeBSD.org>; Wed, 24 Dec 2014 01:24:19 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 196243] New: [bhyve] vmrun.sh doesn't recognise zvol diskdev
Date: Wed, 24 Dec 2014 01:24:19 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: misc
X-Bugzilla-Version: 10.1-RELEASE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: paul.chakravarti@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-196243-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Dec 2014 01:24:19 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196243

            Bug ID: 196243
           Summary: [bhyve] vmrun.sh doesn't recognise zvol diskdev
           Product: Base System
           Version: 10.1-RELEASE
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: misc
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: paul.chakravarti@gmail.com

Hello,

I noticed that there is a minor problem in the vmrun.sh script if you are using
a zvol as the virtio_diskdev. The 'make_and_check_diskdev' check will fail if
virtio_diskdev is a zvol as it only checks for files (vs char devices). This is
harmless as the truncate doesn't actually do anything if the device is a zvol
however the attached small patch fixes the problem and removes the spurious
error message.

Paul


--- vmrun.sh.orig       2014-12-24 01:56:58.468954569 +0100
+++ vmrun.sh    2014-12-24 02:03:23.543145433 +0100
@@ -152,7 +152,7 @@
 {
     local virtio_diskdev="$1"
     # Create the virtio diskdev file if needed
-    if [ ! -f ${virtio_diskdev} ]; then
+    if [ ! -f ${virtio_diskdev} -a ! -c ${virtio_diskdev} ]; then
            echo "virtio disk device file \"${virtio_diskdev}\" does not
exist."
            echo "Creating it ..."
            truncate -s 8G ${virtio_diskdev} > /dev/null

-- 
You are receiving this mail because:
You are the assignee for the bug.