From owner-p4-projects@FreeBSD.ORG  Fri Jan 18 14:23:03 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2DC9116A46E; Fri, 18 Jan 2008 14:23:03 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CF44B16A469;
	Fri, 18 Jan 2008 14:23:02 +0000 (UTC) (envelope-from bms@FreeBSD.org)
Received: from out3.smtp.messagingengine.com (out3.smtp.messagingengine.com
	[66.111.4.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 8B85E13C458;
	Fri, 18 Jan 2008 14:23:02 +0000 (UTC) (envelope-from bms@FreeBSD.org)
Received: from compute1.internal (compute1.internal [10.202.2.41])
	by out1.messagingengine.com (Postfix) with ESMTP id 472C28AFD9;
	Fri, 18 Jan 2008 09:05:17 -0500 (EST)
Received: from heartbeat1.messagingengine.com ([10.202.2.160])
	by compute1.internal (MEProxy); Fri, 18 Jan 2008 09:05:17 -0500
X-Sasl-enc: YDl15dGfkG1t7pvCQMS8/73u/SJCkIMsHm5mBxUDWHQV 1200665117
Received: from empiric.lon.incunabulum.net
	(82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254])
	by mail.messagingengine.com (Postfix) with ESMTP id C8398EB57;
	Fri, 18 Jan 2008 09:05:16 -0500 (EST)
Message-ID: <4790B21B.3000102@FreeBSD.org>
Date: Fri, 18 Jan 2008 14:05:15 +0000
From: "Bruce M. Simpson" <bms@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.6 (X11/20070928)
MIME-Version: 1.0
To: Warner Losh <imp@FreeBSD.org>
References: <200801180525.m0I5PKss045795@repoman.freebsd.org>
In-Reply-To: <200801180525.m0I5PKss045795@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 133522 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jan 2008 14:23:03 -0000

Warner Losh wrote:
> http://perforce.freebsd.org/chv.cgi?CH=133522
>
> Change 133522 by imp@imp_paco-paco on 2008/01/18 05:25:09
>
> 	Prefer ${SHELL} to sh, since I like it.  Sadly, I got complaints
> 	when I proposed it for -current.
>   

The source of the objection might be that GNU make is known to prefer 
bash -- and I've torn my hair out on more than one occasion because of 
this behaviour.

However, buildenv is a target which explicitly forks an interactive 
shell, so the use of SHELL seems reasonable in this instance.

cheers
BMS