From owner-cvs-ports@FreeBSD.ORG  Fri Jun 11 21:53:32 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9CAE5106567B
	for <cvs-ports@FreeBSD.org>; Fri, 11 Jun 2010 21:53:32 +0000 (UTC)
	(envelope-from lx@redundancy.redundancy.org)
Received: from redundancy.redundancy.org (75-101-96-57.dsl.static.sonic.net
	[75.101.96.57]) by mx1.freebsd.org (Postfix) with SMTP id 55EDB8FC16
	for <cvs-ports@FreeBSD.org>; Fri, 11 Jun 2010 21:53:32 +0000 (UTC)
Received: (qmail 25433 invoked by uid 1001); 11 Jun 2010 21:53:06 -0000
Date: Fri, 11 Jun 2010 14:53:06 -0700
From: "David E. Thiel" <lx@redundancy.redundancy.org>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20100611215306.GI2603@redundancy.redundancy.org>
References: <201006111649.o5BGn8Wh043693@repoman.freebsd.org>
	<4C129CB0.8000103@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C129CB0.8000103@FreeBSD.org>
X-OpenPGP-Key-fingerprint: 482A 8C46 C844 7E7C 8CBC 2313 96EE BEE5 1F4B CA13
X-OpenPGP-Key-available: http://redundancy.redundancy.org/lx.gpg
X-Face: %H~{$1~NOw1y#%mM6{|4:/<p]y9X%E+4%:1wo-M!re,
	zl.qH~yzbL-MWhtp$3QuKP&di/a{FOctD[FuX.\n4U*,
	M{TJg$oYp663.NyX!%H~~Tw$eR9xZU5W?1BM#t"a@'27^2x
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: cvs-ports@FreeBSD.org, Kelly Hays <kelly.hays@jkhfamily.org>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net-im/prosody Makefile
 ports/net-im/prosody/files prosody.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2010 21:53:32 -0000

On Fri, Jun 11, 2010 at 01:29:36PM -0700, Doug Barton wrote:
> There is a problem with the change here in that the literal /usr/local 
> should be replaced with %%PREFIX%%. However the whole script needs some 
> work. 

Thanks Doug, I should have caught that.

> 4. Simplify the status and stop methods down to one function that takes 
> an argument.

This works mostly well, but I notice that the "restart" command
doesn't work, and was going to add a restart_cmd telling it to issue a
prosodyctl stop followed by prosodyctl start. I kind of think it would
look cleaner to have start_cmd, stop_cmd and restart_cmd rather than
prosody_cmd and restart_cmd. Thoughts?

Thanks,
David