From owner-freebsd-ports@FreeBSD.ORG Tue Oct 21 09:36:12 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9DC031065679 for ; Tue, 21 Oct 2008 09:36:12 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from mailrelay.rz.uni-wuerzburg.de (mailrelay.rz.uni-wuerzburg.de [132.187.3.28]) by mx1.freebsd.org (Postfix) with ESMTP id 23AF68FC0C for ; Tue, 21 Oct 2008 09:36:12 +0000 (UTC) (envelope-from shuvaev@physik.uni-wuerzburg.de) Received: from virusscan.mail (localhost [127.0.0.1]) by mailrelay.mail (Postfix) with ESMTP id 1583A198E45; Tue, 21 Oct 2008 11:36:10 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by virusscan.mail (Postfix) with ESMTP id 071D6198E36; Tue, 21 Oct 2008 11:36:10 +0200 (CEST) Received: from mail.physik.uni-wuerzburg.de (wthp192.physik.uni-wuerzburg.de [132.187.40.192]) by mailmaster.uni-wuerzburg.de (Postfix) with ESMTP id E5AB9198E29; Tue, 21 Oct 2008 11:36:09 +0200 (CEST) Received: from wep4035 ([132.187.37.35]) by mail.physik.uni-wuerzburg.de (Lotus Domino Release 8.0.2) with ESMTP id 2008102111360916-19550 ; Tue, 21 Oct 2008 11:36:09 +0200 Received: by wep4035 (sSMTP sendmail emulation); Tue, 21 Oct 2008 11:36:08 +0200 From: "Alexey Shuvaev" Date: Tue, 21 Oct 2008 11:36:08 +0200 To: Michael Proto Message-ID: <20081021093608.GA28266@wep4035.physik.uni-wuerzburg.de> References: <1de79840810141617y27fb7779xfd8f334f8b7ff2e1@mail.gmail.com> MIME-Version: 1.0 In-Reply-To: <1de79840810141617y27fb7779xfd8f334f8b7ff2e1@mail.gmail.com> Organization: Universitaet Wuerzburg User-Agent: Mutt/1.5.18 (2008-05-17) X-MIMETrack: Itemize by SMTP Server on domino1/uni-wuerzburg(Release 8.0.2|August 07, 2008) at 10/21/2008 11:36:09 AM, Serialize by Router on domino1/uni-wuerzburg(Release 8.0.2|August 07, 2008) at 10/21/2008 11:36:09 AM, Serialize complete at 10/21/2008 11:36:09 AM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Virus-Scanned: by amavisd-new at uni-wuerzburg.de Cc: mbr@freebsd.org, freebsd-ports@freebsd.org Subject: Re: open-vm-tools fails on a recent sup to CURRENT X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2008 09:36:12 -0000 On Tue, Oct 14, 2008 at 07:17:29PM -0400, Michael Proto wrote: > Has anyone started seeing failures of ports/emulators/open-vm-tools builds > with a recent current? I csup-ed my source recently (as of 20080926), > rebuilt world and my kernel, and open-vm-tools builds fail in the vmhgfs > module with the following: > > > ... > cc1: warnings being treated as errors > vfsops.c: In function 'HgfsVfsMount': > vfsops.c:142: warning: implicit declaration of function 'suser' > vfsops.c:142: warning: nested extern declaration of 'suser' > *** Error code 1 > ... > > I've tried setting CFLAGS optimizations to -Os (my default), -O, -O2 and no > optimizations and it fails with the same error every time. Has anyone else > using CURRENT in VMware seen this error recently? Any ideas? > This is due to API change suser() -> priv_check(). Have a look at http://www.freebsd.org/cgi/cvsweb.cgi/ports/x11/nvidia-driver/Makefile (revision 1.81) for example. I am not sure about "PRIV_DRIVER" argument, but you can try to replace "suser(CURTHREAD)" to "priv_check(CURTHREAD, PRIV_DRIVER)" in the open-vm-tools sources. Alexey.