From owner-cvs-ports@FreeBSD.ORG  Sun Sep  4 04:21:58 2011
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 27DD11065670;
	Sun,  4 Sep 2011 04:21:58 +0000 (UTC)
	(envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
	by mx1.freebsd.org (Postfix) with ESMTP id 04A768FC0C;
	Sun,  4 Sep 2011 04:21:57 +0000 (UTC)
Received: from g159.suse.de (charybdis-ext.suse.de [195.135.221.2])
	by ainaz.pair.com (Postfix) with ESMTPSA id 9765D3F416;
	Sun,  4 Sep 2011 00:03:20 -0400 (EDT)
Date: Sun, 4 Sep 2011 06:03:19 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Philippe Audeoud <jadawin@freebsd.org>, Brendan Fabeny <bf1783@gmail.com>
In-Reply-To: <BANLkTimr3O_Dt2OqCkCcPQ1YduBdLtSGYg@mail.gmail.com>
Message-ID: <alpine.LNX.2.00.1109040549550.4335@gerinyyl.fvgr>
References: <201105301136.p4UBaOg9066272@repoman.freebsd.org>
	<BANLkTimr3O_Dt2OqCkCcPQ1YduBdLtSGYg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: cvs commit: ports/finance/quantlib Makefile distinfo pkg-plist
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Sep 2011 04:21:58 -0000

On Mon, 30 May 2011, b. f. wrote:
> CPPFLAGS is now added to MAKE_ENV in bsd.port.mk, so it is unnecessary
> to add it here, in the port Makefile.  I'm not sure why portlint warns
> about this addition in the case of CONFIGURE_ENV, but not MAKE_ENV.
> The original request for this warning,
> 
> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=155550
> 
> , asked for checks in both cases.

Philippe, I see you did not make the change Brendan asked for; may
I apply the patch below?

Brendan, as for your observation, I just filed PR/160448.

Gerald

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/finance/quantlib/Makefile,v
retrieving revision 1.32
diff -u -r1.32 Makefile
--- Makefile	30 May 2011 11:36:24 -0000	1.32
+++ Makefile	4 Sep 2011 03:49:52 -0000
@@ -23,7 +23,7 @@
 GNU_CONFIGURE=	yes
 CPPFLAGS=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include
 LDFLAGS=	${PTHREAD_LIBS} -L${LOCALBASE}/lib
-MAKE_ENV=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
+MAKE_ENV=	LDFLAGS="${LDFLAGS}"
 USE_LDCONFIG=	yes
 
 MAN1=		quantlib-config.1 quantlib-test-suite.1