From owner-svn-src-all@FreeBSD.ORG Sat Dec 20 13:51:31 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 01BE5C6A; Sat, 20 Dec 2014 13:51:31 +0000 (UTC) Received: from mail-wi0-x234.google.com (mail-wi0-x234.google.com [IPv6:2a00:1450:400c:c05::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 820032857; Sat, 20 Dec 2014 13:51:30 +0000 (UTC) Received: by mail-wi0-f180.google.com with SMTP id n3so4299482wiv.1; Sat, 20 Dec 2014 05:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=7sHzxg/gYsDyJ9IoUan2A11T0SWEUGTZzyk8qEwZtNo=; b=p9DJZFRqE8/tDxjmOr1sOggVIDkJS3ScV+2a7mIyRIZ+eqif+HA83nIRuKd80CnG4e zQOa8wwETLwHHRjJwYNbQMwTnkC6dOay9RetFF5Y3I/+agySnTxUx99kxYt27+PxUVuJ Nw//3Q5r9BfRAwFGHAaEuzQUSwoi1g+RMEjxWblOJ78PJjKy8qFLVsvlK8lkMNSE185D vnFluK3+YrOuwLbFuq+N+UXiMKyFUX8SOZvwYHmqqmlbzYRNkY34m7LazHADSCQFfMBs MVFLpZYDF1G7S9i+MKBWDA4EbfKZ3FSAPhyVRkw30FQUOFx6Yyz4KTa6BZv0oq2cu2sr J+cA== X-Received: by 10.180.13.7 with SMTP id d7mr15047506wic.57.1419083488820; Sat, 20 Dec 2014 05:51:28 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id p1sm16415657wjy.22.2014.12.20.05.51.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Dec 2014 05:51:27 -0800 (PST) Sender: Baptiste Daroussin Date: Sat, 20 Dec 2014 14:51:25 +0100 From: Baptiste Daroussin To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Subject: Re: svn commit: r275768 - in head/usr.sbin: . vigr Message-ID: <20141220135125.GE21894@ivaldir.etoilebsd.net> References: <201412141640.sBEGelm0072509@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sfyO1m2EN8ZOtJL6" Content-Disposition: inline In-Reply-To: <201412141640.sBEGelm0072509@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Dec 2014 13:51:31 -0000 --sfyO1m2EN8ZOtJL6 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 14, 2014 at 04:40:47PM +0000, Dag-Erling Sm=F8rgrav wrote: > Author: des > Date: Sun Dec 14 16:40:46 2014 > New Revision: 275768 > URL: https://svnweb.freebsd.org/changeset/base/275768 >=20 > Log: > Add a vigr(8) utility which does for /etc/group what vipw(8) does for > /etc/master.passwd. >=20 > Added: > head/usr.sbin/vigr/ > head/usr.sbin/vigr/Makefile (contents, props changed) > head/usr.sbin/vigr/vigr.8 (contents, props changed) > head/usr.sbin/vigr/vigr.sh (contents, props changed) I wonder why you chose making a script instead of using libutil? gr_* have = now the same level of features as of pw_* the benifit would have been to be abl= e to share the code with vipw(8) (maybe just have vigr(8) a hardlink so vipw(8))= and to allow transparent change if one day he have a group db (aka gr_mkdb() is= now a simple rename(2) but could be changed to generate a db like pw_mkdb() doe= s). Best regards, Bapt --sfyO1m2EN8ZOtJL6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlSVftcACgkQ8kTtMUmk6Eyj+QCgh3S3FfLYKHSmEGOaL+auvNkR KM0AoJpN+4xm8Hto360Y6hC9ExGjTJT0 =BDIl -----END PGP SIGNATURE----- --sfyO1m2EN8ZOtJL6--