From owner-freebsd-stable@FreeBSD.ORG Tue May 8 12:31:47 2007 Return-Path: X-Original-To: stable@FreeBSD.org Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 67E1B16A401 for ; Tue, 8 May 2007 12:31:47 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 3E80513C458 for ; Tue, 8 May 2007 12:31:47 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 9CC264715B for ; Tue, 8 May 2007 08:31:46 -0400 (EDT) Date: Tue, 8 May 2007 13:31:46 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: stable@FreeBSD.org Message-ID: <20070508132149.A24765@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Subject: UNIX domain sockets MFC's X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2007 12:31:47 -0000 Dear all, I have just completed the merge of a significant number of UNIX domain socket bug fixes and cleanups from HEAD to RELENG_6. While my hope is that these are generally low-risk, and should improve UNIX domain socket stability and performance under load, there were quite a few changes involved. As such, please keep an eye out for any new problems with UNIX domain sockets, and drop me an e-mail if you run into any. The changes in the recent MFC spree include: - Additional MAC check for UNIX domain socket connect(). - Cleanup of structure, comments, white space, and consolidation of uipc_proto.c into uipc_usrreq.c. Removal of redundant code. - Fixed races involving simultaneous bind() and connect() between two threads or processes on the same UNIX domain socket. - Reduced period of overlapped acquisition of socket buffer mutexes during send/receive, which should lower lock contention under load. Right now I am tracking two known issues with UNIX domain sockets in RELENG_6: - Reported NULL point derference in unp_connect(), which occurs due to the dropping of locks around sonewconn(). This is fixed in HEAD, and I am preparing an MFC of this patch. - Reported UNIX domain socket connection leak. This is not yet fully diagnosed. Robert N M Watson Computer Laboratory University of Cambridge