From owner-p4-projects  Tue Mar 19 11:47:21 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 645AC37B416; Tue, 19 Mar 2002 11:46:59 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38])
	by hub.freebsd.org (Postfix) with ESMTP
	id B4A8A37B429; Tue, 19 Mar 2002 11:46:09 -0800 (PST)
Received: from peter3.wemm.org ([12.232.27.13]) by rwcrmhc51.attbi.com
          (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP
          id <20020319194601.DZDV2626.rwcrmhc51.attbi.com@peter3.wemm.org>;
          Tue, 19 Mar 2002 19:46:01 +0000
Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3])
	by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id g2JJk1s66382;
	Tue, 19 Mar 2002 11:46:01 -0800 (PST)
	(envelope-from peter@wemm.org)
Received: from wemm.org (localhost [127.0.0.1])
	by overcee.wemm.org (Postfix) with ESMTP
	id B2BB33810; Tue, 19 Mar 2002 11:46:00 -0800 (PST)
	(envelope-from peter@wemm.org)
X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4
To: John Baldwin <jhb@FreeBSD.org>
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 7933 for review 
In-Reply-To: <XFMail.20020319131141.jhb@FreeBSD.org> 
Date: Tue, 19 Mar 2002 11:46:00 -0800
From: Peter Wemm <peter@wemm.org>
Message-Id: <20020319194600.B2BB33810@overcee.wemm.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

John Baldwin wrote:
> 
> On 19-Mar-2002 Peter Wemm wrote:
> > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=7933
> > 
> > Change 7933 by peter@peter_overcee on 2002/03/19 01:29:12
> > 
> >       add the ia64 IO tag, and add a #error to catch this in future.
> > 
> > Affected files ...
> > 
> > ... //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 edit
> > 
> > Differences ...
> > 
> > ==== //depot/projects/ia64/sys/dev/kbd/atkbdc.c#2 (text+ko) ====
> > 
> > @@ -159,6 +159,10 @@
> >       tag = I386_BUS_SPACE_IO;
> >  #elif defined(__alpha__)
> >       tag = busspace_isa_io;
> > +#elif defined(__ia64__)
> > +     tag = IA64_BUS_SPACE_IO;
> > +#else
> > +#error "define tag!"
> >  #endif
> >  
> >  #if notyet
> 
> Maybe there should be a MD macro to define what the appropriate bus tag is?

Actually, this should use the proper API's instead of hacking around like
this.

Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message