From owner-freebsd-hackers@FreeBSD.ORG Wed Nov 10 08:44:43 2010 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC09B106564A for ; Wed, 10 Nov 2010 08:44:43 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4DAD98FC13 for ; Wed, 10 Nov 2010 08:44:42 +0000 (UTC) Received: by wwi17 with SMTP id 17so3248wwi.1 for ; Wed, 10 Nov 2010 00:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=XLDtMMoCRR+wW420CFey/s0K4j4gYG5pHfJYeo9XdXY=; b=N4JriP68L9tgMeYYswcL0QAo/FnpfvbuKzzdC1+onllxYho0fIUKotXUprlI8Jellt cVOGvZ/C9VAbB5TGH9kHp06ccgycK71eHgJl6T/soB/iIlhaUImrRE/V3NtzvgceCCK6 yrr2e9dGO2K6mlgAc4ygJ1RqsIQmvtg+iLooY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=w8SaoycRh1gr7EeLJh7Bepgu/CZovsCuUPR2nJePb/TqCPwmpp9j2jO5WA/JQ2KaCy /HFYSCGHa24Rs5MBpTyRFv+rDcyZshk7yamcGoXgdvS/Izj+j9VbNAL/Nv+jwWiILjRZ pnLu6BLRVSDA/1oFOf5qfsD2AguI99sYzRD7E= MIME-Version: 1.0 Received: by 10.216.46.200 with SMTP id r50mr786359web.45.1289378681216; Wed, 10 Nov 2010 00:44:41 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.198.27 with HTTP; Wed, 10 Nov 2010 00:44:41 -0800 (PST) In-Reply-To: <478E6244-00B4-4D96-93FE-CBD546C27A6E@mac.com> References: <478E6244-00B4-4D96-93FE-CBD546C27A6E@mac.com> Date: Wed, 10 Nov 2010 00:44:41 -0800 X-Google-Sender-Auth: EvvRBMtkMDDeeDMLmfgxBT2VluY Message-ID: From: Garrett Cooper To: Marcel Moolenaar Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: hackers@freebsd.org Subject: Re: [PATCH] Simplify uart_bus_pci_probe X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 08:44:43 -0000 On Tue, Nov 9, 2010 at 10:29 PM, Marcel Moolenaar wrote: > > On Nov 6, 2010, at 11:22 AM, Garrett Cooper wrote: > >> =A0 =A0Some of the logic could have been simplified in the probe. The >> proposed patch makes the detection process a tad bit more >> straightforward. >> =A0 =A0Comments, review (and maybe a commit :P) are more than welcome :)= . > > The patch is logically wrong for non-ns8250 based UARTs. > Leave the code as is. Hi Marcel, Is the layout of the pci_ns8250_ids PCI ID table correct then, as there are a large number of ns16550 chips and other non-ns8250 chips in the table? Thanks, -Garrett