From owner-freebsd-current@FreeBSD.ORG  Sun Nov  7 18:15:42 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E10EA16A4CE
	for <current@freebsd.org>; Sun,  7 Nov 2004 18:15:42 +0000 (GMT)
Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net
	[66.166.149.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 47F1243D45
	for <current@freebsd.org>; Sun,  7 Nov 2004 18:15:42 +0000 (GMT)
	(envelope-from kientzle@freebsd.org)
Received: from freebsd.org (p54.kientzle.com [66.166.149.54])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id iA7IFf90063120;
	Sun, 7 Nov 2004 10:15:41 -0800 (PST)
	(envelope-from kientzle@freebsd.org)
Message-ID: <418E664A.1080709@freebsd.org>
Date: Sun, 07 Nov 2004 10:15:38 -0800
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
References: <25080.1099840843@critter.freebsd.dk>
In-Reply-To: <25080.1099840843@critter.freebsd.dk>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: current@freebsd.org
Subject: Re: bsdtar breakage ?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Nov 2004 18:15:43 -0000

Poul-Henning Kamp wrote:
> i386 -current buildworld:
> 
> ===> gnu/usr.bin/tar (all)
> /bang/src1/src/gnu/usr.bin/tar/../../../contrib/tar/src/create.c: In function `mode_to_chars':
> /bang/src1/src/gnu/usr.bin/tar/../../../contrib/tar/src/create.c:264: warning: comparison is always false due to limited range of data type
> ===> gnu/usr.bin/tar/doc (all)
> ===> gnu/usr.bin/texinfo (all)

This is gtar.

The relevant code here is:
     mode_t v;
     int negative;
     negative = v < 0;

Since mode_t is unsigned, the comparison
"v < 0" is always false, hence the warning.

This file hasn't been touched in over two years.
mode_t has been unsigned for at least that long.

I smell a compiler upgrade.  ;-)

Tim