From owner-svn-src-all@freebsd.org Sun May 15 00:07:15 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2049CB32158; Sun, 15 May 2016 00:07:15 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-ig0-x22e.google.com (mail-ig0-x22e.google.com [IPv6:2607:f8b0:4001:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DDB4E1982; Sun, 15 May 2016 00:07:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-ig0-x22e.google.com with SMTP id m9so26292283ige.1; Sat, 14 May 2016 17:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xbGL4WEWtKl2yid8WASdOOXOopvnddOUiJp8QTmzxh0=; b=ivPvLzbG9QEZCRcjWSf9hQQ3rpFqhDcy+xO7tt5i2A7+Eg0Csy79R0kR3SBDpxAeGf sm8lMUn5i2BtHfyqCIdsGDyepFL7HihDFZ9CkSYGj1e4FTN+poZcmkRKI59ezhnUvZAd TJ2w7O3FJP9rXnT0jJ0VeXZ1fsFPwsaQK/Jucg7lk/Kq4+L7v4kRDy60PyI88IUn3D62 iTqNFw7Y7iqqdTsrUihJVehtU76K5VxqrGg+CP8KH+bL6kiqefx4WzkVgM3yx/IdTkIT BREbsjOFXZgchpb+Q99BUNoYQJN39l4BC6ZvzFzhQ2kgiKYn+0jbNS4asLPO9aF7R3aS f9wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xbGL4WEWtKl2yid8WASdOOXOopvnddOUiJp8QTmzxh0=; b=iWGronFCGPEXx8m0jRjFkf9co66Igg2eXq+pm0mFnXsBnCKJc9u0OxWIUtBUYHX6rt aq4BSeI5NfcC7Hqp7Xrs47+GOyelCVOd7nmgQP9SMHvNNq8Z/bKEgmb375WqcSgpi7HA JogcKOsRGz6LTmTbqYlETlocQJIh6qFal5pmx8HigNDcq1bvVD3eDsWMHUfOaMIAd4Dq RtVofL/uQb9n91alGQblQy0guuXzgcqc0f2G77IpWhyZbBaY8iaaYrN70PUUOegi1x73 uDW0MSBw09jQ3FJvoDACJjIKKZcOCnWcpc8sYLVvK2EPEUCufELXX93ImegaWko9oxI1 vxWA== X-Gm-Message-State: AOPr4FX10it/7DzYoA6A6UqnstXXiYx/70HQ6chwM3ShC1UP/70UhqDShEjMs9VZ78iLsA== X-Received: by 10.50.63.228 with SMTP id j4mr4815125igs.25.1463270834219; Sat, 14 May 2016 17:07:14 -0700 (PDT) Received: from [192.168.20.7] (c-73-97-222-46.hsd1.wa.comcast.net. [73.97.222.46]) by smtp.gmail.com with ESMTPSA id e101sm8369777iod.29.2016.05.14.17.07.13 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 14 May 2016 17:07:13 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r299770 - head/usr.sbin/bsnmpd/tools/libbsnmptools From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20160515093254.R2601@besplex.bde.org> Date: Sat, 14 May 2016 17:07:13 -0700 Cc: Garrett Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <53C0F48B-50C4-4453-849E-B84DC5CC5D56@gmail.com> References: <201605142243.u4EMh75e071378@repo.freebsd.org> <20160515093254.R2601@besplex.bde.org> To: Bruce Evans X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 May 2016 00:07:15 -0000 > On May 14, 2016, at 16:42, Bruce Evans wrote: >=20 > On Sat, 14 May 2016, Garrett Cooper wrote: =E2=80=A6 > Er, this is pointier than before. nitems() is only valid on arrays. You=E2=80=99re 100% correct. I forgot that it isn=E2=80=99t a magic = silver bullet that works with scalar pointers :(=E2=80=A6 >> Modified: head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c Sat May = 14 22:40:35 2016 (r299769) >> +++ head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c Sat May = 14 22:43:07 2016 (r299770) >> @@ -264,7 +264,7 @@ add_filename(struct snmp_toolinfo *snmpt >>=20 >> if (cut !=3D NULL) >> asn_append_oid(&(entry->cut), cut); >> - strlcpy(fstring, filename, sizeof(fstring)); >> + strlcpy(fstring, filename, nitems(fstring)); >=20 > fstring is pointer to char, so nitems(fstring) =3D sizeof(char *) / 1 > sizeof(char *) =3D accidentally the same wrong value as before. >=20 > The old code using strlen() had a chance of being correct. The old and new code was implementing strdup in a longhand way. I just = converted everything to strdup.=