From owner-cvs-all@FreeBSD.ORG Thu Dec 29 23:06:32 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B30D16A420; Thu, 29 Dec 2005 23:06:32 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id C6A9043D70; Thu, 29 Dec 2005 23:06:16 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 471CF52CC5; Fri, 30 Dec 2005 00:06:15 +0100 (CET) Received: from localhost (djy35.neoplus.adsl.tpnet.pl [83.24.2.35]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id D2FCB52C88; Fri, 30 Dec 2005 00:06:05 +0100 (CET) Date: Fri, 30 Dec 2005 00:06:05 +0100 From: Pawel Jakub Dawidek To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20051229230604.GA22411@garage.freebsd.pl> References: <200512292252.jBTMq9FQ087829@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sm4nu43k4a2Rpi4c" Content-Disposition: inline In-Reply-To: <200512292252.jBTMq9FQ087829@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: Subject: Re: cvs commit: src/sys/kern vfs_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Dec 2005 23:06:32 -0000 --sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 29, 2005 at 10:52:09PM +0000, Pawel Jakub Dawidek wrote: +> pjd 2005-12-29 22:52:09 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> sys/kern vfs_subr.c=20 +> Log: +> Print a warning when we miss vinactive() call, because of race in vget= (). +> The race is very real, but conditions needed for triggering it are rat= her +> hard to meet now. +> When gjournal will be committed (where it is quite easy to trigger) we= need +> to fix it. +> =20 +> For now, verify if it is really hard to trigger. +> =20 +> Discussed with: kan [...] +> + if (usecount > 0 && vp->v_usecount =3D=3D 0) +> + printf("vinactive() won't be called for vp=3D%p\n", vp); Hmm, maybe it should be: if (usecount > 0 && vp->v_usecount =3D=3D 0 && oweinact) ? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --sm4nu43k4a2Rpi4c Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDtGvcForvXbEpPzQRAvZeAKDkJf1ZPV4lyOJaR8cy5lJOCO1/uwCggLlH Qgx6LvPd8Qx1PSthUfvK80U= =w4C/ -----END PGP SIGNATURE----- --sm4nu43k4a2Rpi4c--