From owner-p4-projects@FreeBSD.ORG  Thu Nov  2 23:30:27 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4E7AF16A415; Thu,  2 Nov 2006 23:30:27 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2DA8216A403
	for <perforce@freebsd.org>; Thu,  2 Nov 2006 23:30:27 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B853A43D64
	for <perforce@freebsd.org>; Thu,  2 Nov 2006 23:30:21 +0000 (GMT)
	(envelope-from mjacob@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kA2NULUW091333
	for <perforce@freebsd.org>; Thu, 2 Nov 2006 23:30:21 GMT
	(envelope-from mjacob@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kA2NULcV091330
	for perforce@freebsd.org; Thu, 2 Nov 2006 23:30:21 GMT
	(envelope-from mjacob@freebsd.org)
Date: Thu, 2 Nov 2006 23:30:21 GMT
Message-Id: <200611022330.kA2NULcV091330@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	mjacob@freebsd.org using -f
From: Matt Jacob <mjacob@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 109080 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Nov 2006 23:30:27 -0000

http://perforce.freebsd.org/chv.cgi?CH=109080

Change 109080 by mjacob@newisp on 2006/11/02 23:30:18

	Replace PPR options bounce with a comment asserting that we
	don't have to care about changing PPR options.

Affected files ...

.. //depot/projects/newisp/cam/cam_xpt.c#8 edit

Differences ...

==== //depot/projects/newisp/cam/cam_xpt.c#8 (text+ko) ====

@@ -5907,13 +5907,10 @@
 	}
 
 	/*
-	 * XXX: skipping PPR options
+	 * We'll assert that we don't have to touch PPR options- the
+	 * SIM will see what we do with period and offset and adjust
+	 * the PPR options as appropriate.
 	 */
-	if ((spi->valid & CTS_SPI_VALID_PPR_OPTIONS) != 0) {
-		xpt_print_path(periph->path);
-		printf("XXX PPR options not handled yet\n");
-		return (0);
-	}
 
 	/*
 	 * A sync rate with unknown or zero offset is nonsensical.