From owner-cvs-all@FreeBSD.ORG Thu Jan 22 00:29:47 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2157516A4D0 for ; Thu, 22 Jan 2004 00:29:47 -0800 (PST) Received: from tx1.oucs.ox.ac.uk (tx1.oucs.ox.ac.uk [129.67.1.167]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35D5043D46 for ; Thu, 22 Jan 2004 00:29:41 -0800 (PST) (envelope-from colin.percival@wadham.ox.ac.uk) Received: from scan1.oucs.ox.ac.uk ([129.67.1.166] helo=localhost) by tx1.oucs.ox.ac.uk with esmtp (Exim 4.24) id 1AjaDc-0004cP-HH for cvs-all@FreeBSD.org; Thu, 22 Jan 2004 08:29:40 +0000 Received: from rx1.oucs.ox.ac.uk ([129.67.1.165]) by localhost (scan1.oucs.ox.ac.uk [129.67.1.166]) (amavisd-new, port 25) with ESMTP id 17666-04 for ; Thu, 22 Jan 2004 08:29:40 +0000 (GMT) Received: from gateway.wadham.ox.ac.uk ([163.1.161.253]) by rx1.oucs.ox.ac.uk with smtp (Exim 4.24) id 1AjaDc-0004cJ-3o for cvs-all@FreeBSD.org; Thu, 22 Jan 2004 08:29:40 +0000 Received: (qmail 6889 invoked by uid 0); 22 Jan 2004 08:29:40 -0000 Received: from colin.percival@wadham.ox.ac.uk by gateway by uid 71 with qmail-scanner-1.16 (sweep: 2.14/3.71. spamassassin: 2.53. Clear:. Processed in 1.561843 secs); 22 Jan 2004 08:29:40 -0000 X-Qmail-Scanner-Mail-From: colin.percival@wadham.ox.ac.uk via gateway X-Qmail-Scanner: 1.16 (Clear:. Processed in 1.561843 secs) Received: from dhcp1131.wadham.ox.ac.uk (HELO piii600.wadham.ox.ac.uk) (163.1.161.131) by gateway.wadham.ox.ac.uk with SMTP; 22 Jan 2004 08:29:38 -0000 Message-Id: <6.0.1.1.1.20040122082056.04321990@imap.sfu.ca> X-Sender: cperciva@imap.sfu.ca (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.0.1.1 Date: Thu, 22 Jan 2004 08:28:41 +0000 To: Mike Makonnen From: Colin Percival In-Reply-To: <20040122074937.GB1013@mobile.acsolutions.com> References: <200401211643.i0LGhT43093728@repoman.freebsd.org> <20040122074937.GB1013@mobile.acsolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_rule.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2004 08:29:47 -0000 At 07:49 22/01/2004, Mike Makonnen wrote: >On Wed, Jan 21, 2004 at 08:43:29AM -0800, Colin Percival wrote: > > Allow devfs path rules to work on directories. Without this fix, > > devfs rule add path fd unhide > > is a no-op, while it should unhide the fd subdirectory. > >Does this affect /etc/defaults/devfs.rules? No, but we might want to change devfs.rules. >I am assuming that the 'add hide' in the first ruleset will now also >hide /dev/fd (where it previously didn't). The 'add hide' was always hiding /dev/fd. It just wasn't possible to unhide it without unhiding everything. (devfs_rule_matchpath is only called if the rule specifies a path; prior to this fix, it would always return "no, this doesn't match" when applied to a directory.) >In that case will the >'add path fd/* unhide' in a later rule unhide the fd/ directory? Does >it need a separate 'add fd unhide'? Given that 'add path fd/* unhide' currently unhides entries within a hidden directory, it would probably makes sense to add a separate 'add path fd unhide'. :) Colin Percival