From owner-svn-src-all@FreeBSD.ORG Sun Apr 13 01:02:34 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7464A359; Sun, 13 Apr 2014 01:02:34 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2D3611246; Sun, 13 Apr 2014 01:02:33 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s3D12QwX012686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 12 Apr 2014 18:02:27 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s3D12QeL012685; Sat, 12 Apr 2014 18:02:26 -0700 (PDT) (envelope-from jmg) Date: Sat, 12 Apr 2014 18:02:26 -0700 From: John-Mark Gurney To: sbruno@freebsd.org Subject: Re: svn commit: r264269 - in head: sys/conf sys/kern sys/modules sys/modules/imgact_binmisc sys/sys usr.sbin usr.sbin/binmiscctl Message-ID: <20140413010226.GF34745@funkthat.com> References: <201404082010.s38KAMgg091287@svn.freebsd.org> <201404081625.23418.jhb@freebsd.org> <1396994509.2018.12.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1396994509.2018.12.camel@powernoodle.corp.yahoo.com> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Sat, 12 Apr 2014 18:02:27 -0700 (PDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2014 01:02:34 -0000 Sean Bruno wrote this message on Tue, Apr 08, 2014 at 15:01 -0700: > > > Added: > > > head/sys/kern/imgact_binmisc.c (contents, props changed) > > > head/sys/modules/imgact_binmisc/ > > > head/sys/modules/imgact_binmisc/Makefile (contents, props changed) > > > head/sys/sys/imgact_binmisc.h (contents, props changed) > > > head/usr.sbin/binmiscctl/ > > > head/usr.sbin/binmiscctl/Makefile (contents, props changed) > > > head/usr.sbin/binmiscctl/binmiscctl.8 (contents, props changed) > > > head/usr.sbin/binmiscctl/binmiscctl.c (contents, props changed) > > > Modified: > > > head/sys/conf/files.amd64 > > > head/sys/conf/files.i386 > > > head/sys/modules/Makefile > > > head/usr.sbin/Makefile > > > > Maybe put it in sys/conf/files instead of only amd64|i386? You enabled > > the module build for all architectures. Please also add it to sys/conf/NOTES. > > > I've adjusted things to only build on amd64/i386. Thank you for > pointing out my misconfiguration. > > I've updated NOTES as well at svn r264280 to reflext this and updated > options for amd64/i386. > > I haven't tested on non-x86 h/w and have no idea if it works or not. I > didn't feel comfortable building this driver in the non-x86 case. If > there is a use case/tester for the other arch's, I'll be more than happy > to change this. Can we make sure that this choice is well documented? Too often things are marked for a particular arch w/o notice why it is limited, and this just continues to make non-i386/amd64 arches harder to become first class citzens as people will say feature X is broken on arch Y for no good reason... If you believe it should work on all archs, make it available for all and send out a call for testers to the various lists... Thanks. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."