From owner-svn-src-all@FreeBSD.ORG  Sun Apr 13 01:43:57 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 12981DA4;
 Sun, 13 Apr 2014 01:43:57 +0000 (UTC)
Received: from smtp1.multiplay.co.uk (smtp1.multiplay.co.uk [85.236.96.35])
 by mx1.freebsd.org (Postfix) with ESMTP id C58781578;
 Sun, 13 Apr 2014 01:43:56 +0000 (UTC)
Received: by smtp1.multiplay.co.uk (Postfix, from userid 65534)
 id 279F120E7088B; Sun, 13 Apr 2014 01:43:49 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
 smtp1.multiplay.co.uk
X-Spam-Level: **
X-Spam-Status: No, score=2.3 required=8.0 tests=AWL,BAYES_00,DOS_OE_TO_MX,
 FSL_HELO_NON_FQDN_1,HELO_NO_DOMAIN,RDNS_DYNAMIC,STOX_REPLY_TYPE autolearn=no
 version=3.3.1
Received: from r2d2 (82-69-141-170.dsl.in-addr.zen.co.uk [82.69.141.170])
 by smtp1.multiplay.co.uk (Postfix) with ESMTPS id DA4AE20E70885;
 Sun, 13 Apr 2014 01:43:43 +0000 (UTC)
Message-ID: <009FCFC8A87C4A7CBA3BCEEDDB2FB1DC@multiplay.co.uk>
From: "Steven Hartland" <killing@multiplay.co.uk>
To: "Davide Italiano" <davide@FreeBSD.org>, <src-committers@freebsd.org>,
 <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
References: <201404130115.s3D1FbNX048346@svn.freebsd.org>
Subject: Re: svn commit: r264392 -
 head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Date: Sun, 13 Apr 2014 02:43:42 +0100
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="UTF-8"; reply-type=original
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5931
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Apr 2014 01:43:57 -0000

Interesting, I'd be curious to know what the panic for this looks like?

----- Original Message ----- 
From: "Davide Italiano" <davide@FreeBSD.org>


> Author: davide
> Date: Sun Apr 13 01:15:37 2014
> New Revision: 264392
> URL: http://svnweb.freebsd.org/changeset/base/264392
> 
> Log:
>  Fix a panic in zfs_rename().
>  this is due to a wrong dereference of a vnode when it's not locked and
>  can be (potentially) recycled. 'sdvp' cannot be locked on zfs_rename()
>  entry point because the VFS can't be sure that this scenario is
>  LOR-free (it might violate the parent->child lock acquisition rule).
>  Dereference 'tdvp' instead, which is already locked on entry, and access
>  'sdvp' fields only when it's safe, i.e. under ZFS_ENTER scope.
>  
>  While at it, remove the usage of VOP_REALVP, as long as this is a NOP
>  on FreeBSD.