From owner-p4-projects Thu Aug 29 21:15:49 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 2DE5037B401; Thu, 29 Aug 2002 21:15:43 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0C9D37B400; Thu, 29 Aug 2002 21:15:42 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7958143E65; Thu, 29 Aug 2002 21:15:42 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id 672012A893; Thu, 29 Aug 2002 21:15:42 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Jonathan Mini Cc: Perforce Change Reviews Subject: Re: PERFORCE change 16781 for review In-Reply-To: <20020830041012.GF3751@elvis.mu.org> Date: Thu, 29 Aug 2002 21:15:42 -0700 From: Peter Wemm Message-Id: <20020830041542.672012A893@canning.wemm.org> Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Jonathan Mini wrote: > Peter Wemm [peter@wemm.org] wrote : > > > Jonathan Mini wrote: > > > Jonathan Mini [mini@FreeBSD.org] wrote : > > > > > > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=16781 > > > > > > > > Change 16781 by mini@mini_stylus on 2002/08/29 18:57:55 > > > > > > > > Fix a munged file from the previous integ (change 16780). > > > > > > > > Affected files ... > > > > > > > > .. //depot/projects/kse/sys/i386/i386/machdep.c#54 edit > > > > > > This is the second time this has happened to me. > > > > > > Anyone else run into this? > > > > Are you running -current? Either on a SMP box with a kernel more than > > a few days old, or on a penitum4? > > Yeah: > > stylus:~/p4/kse/sys$ uname -a > FreeBSD stylus.haikugeek.com 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Mon Aug 19 2 0:11:42 PDT 2002 mini@stylus.haikugeek.com:/usr/src/sys/i386/compile/ST YLUS i386 > > On a dual Athlon. > > Is it time to upgrade again? Absolutely. I was getting the same corruption on my dual athlon. Fixed here (i386/isa/apic_vector.s): revision 1.85 date: 2002/08/23 21:45:59; author: peter; state: Exp; lines: +1 -1 Ok, somebody please shoot me. The asm I wrote for the ranged IPI shootdown was wrong. It only ever invalidated one page due to me getting the loop terminator wrong. This explains the DISABLE_PG_G effect on SMP. @@ -352,5 +352,5 @@ 1: invlpg (%edx) /* invalidate single page */ addl $PAGE_SIZE, %edx - cmpl %edx, %eax + cmpl %eax, %edx jb 1b You can make just that change if you do not want new adventures. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message