From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 27 09:34:31 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 097D5DC1 for ; Wed, 27 Aug 2014 09:34:31 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA1C239D3 for ; Wed, 27 Aug 2014 09:34:30 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s7R9YUgc082164 for ; Wed, 27 Aug 2014 09:34:30 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 186056] New port: databases/cassandra2 The latest stable release of Apache Cassandra Date: Wed, 27 Aug 2014 09:34:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: marino@FreeBSD.org X-Bugzilla-Status: Patch Ready X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Aug 2014 09:34:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=186056 John Marino changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Open |Patch Ready --- Comment #8 from John Marino --- I sometimes feel very strict when I insist on logs, but when I see new submissions prior to the log attachment, I feel better. :) I was going to move this to patch-ready, but I see some immediate minor issues. MUST BE FIXED: 1) in the post-install and do-install targets, you precede all commands with "@". This suppresses the output and it is not allowed (with an exception made for mkdir commands) 2) It looks like tab alignment is all over the place. Use tabs=8 spaces 3) PORTDOCS is defined unconditionally. Remove the PORT_OPTIONS:MDOCS condition around it. staging takes care of this. (see https://www.freebsd.org/doc/en/books/porters-handbook/install.html#install-documentation ) 4) Remove post-install target, not necessary anymore (done automatically) NOT STRICTLY NECESSSARY BUT FIX IT ANYWAY A) Convert this to OPTIONS_SUB=yes to remove the need for PLIST_SUB https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html B) use _RUN_DEPENDS and _USES (see same page above) Thanks! sorry about that, but either you fix it or a committer has to. -- You are receiving this mail because: You are the assignee for the bug.