From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jun 15 21:10:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D2BCE415 for ; Sat, 15 Jun 2013 21:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id B5CA11983 for ; Sat, 15 Jun 2013 21:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r5FLA1Kv023242 for ; Sat, 15 Jun 2013 21:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r5FLA1gc023241; Sat, 15 Jun 2013 21:10:01 GMT (envelope-from gnats) Resent-Date: Sat, 15 Jun 2013 21:10:01 GMT Resent-Message-Id: <201306152110.r5FLA1gc023241@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kevin Zheng Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 17CE032D for ; Sat, 15 Jun 2013 21:07:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) by mx1.freebsd.org (Postfix) with ESMTP id 0A3A81979 for ; Sat, 15 Jun 2013 21:07:42 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r5FL7fUM047897 for ; Sat, 15 Jun 2013 21:07:41 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r5FL7fiU047892; Sat, 15 Jun 2013 21:07:41 GMT (envelope-from nobody) Message-Id: <201306152107.r5FL7fiU047892@oldred.freebsd.org> Date: Sat, 15 Jun 2013 21:07:41 GMT From: Kevin Zheng To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/179599: [patch] Fix build for devel/cgit on systems with WITHOUT_NLS X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jun 2013 21:10:01 -0000 >Number: 179599 >Category: ports >Synopsis: [patch] Fix build for devel/cgit on systems with WITHOUT_NLS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Jun 15 21:10:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Kevin Zheng >Release: 9.1-RELEASE-p3 >Organization: >Environment: FreeBSD sigma.local 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29 18:11:52 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: I'm one of those few people who set WITHOUT_NLS (or its modern equivalent) because I simply never use NLS anyways. Unfortunately this means that I run in to a lot of problems with ports that want gettext around anyways. When "WITHOUT_NLS=yes" is set in 'make.conf', gettext is not installed in my Poudriere cleanroom build. On normal systems, gettext is usually there, and on Redports, NLS is always built. Hence, this issue isn't usually reported until some poor guy like me comes along. Basically, I can fix the build for me by adding "USES+= gettext" in the port Makefile. Because I am greedy and selfish, I'll do this until I can find a better fix that doesn't require us use something we don't want. Also, take maintainership because I use this port. >How-To-Repeat: Set up a poudriere with "WITHOUT_NLS=yes" set and build cgit. It won't build. >Fix: Apply the attached patch. Patch attached with submission follows: Index: Makefile =================================================================== --- Makefile (revision 321016) +++ Makefile (working copy) @@ -10,8 +10,8 @@ DISTFILES= cgit-${PORTVERSION}${EXTRACT_SUFX}:cgit \ git-${GIT_VERSION}.tar.gz:git -MAINTAINER= ports@FreeBSD.org -COMMENT= Fast webinterface for git +MAINTAINER= kevinz5000@gmail.com +COMMENT= Fast web frontend for Git repositories LICENSE= GPLv2 @@ -19,7 +19,7 @@ GIT_VERSION= 1.8.2.3 USE_BZIP2= yes USE_GMAKE= yes -USES= iconv shebangfix +USES= gettext iconv shebangfix SHEBANG_FILES= filters/html-converters/resources/markdown.pl USE_GMAKE= yes USE_OPENSSL= yes >Release-Note: >Audit-Trail: >Unformatted: