From owner-freebsd-current@FreeBSD.ORG Thu Apr 15 13:52:14 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96DCC16A4CE; Thu, 15 Apr 2004 13:52:14 -0700 (PDT) Received: from huva.hittite.isp.9tel.net (huva.hittite.isp.9tel.net [62.62.156.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id BB5C243D1F; Thu, 15 Apr 2004 13:52:13 -0700 (PDT) (envelope-from cyrille.lefevre@laposte.net) Received: from pc2k (233-60-118-80.kaptech.net [80.118.60.233]) by huva.hittite.isp.9tel.net (Postfix) with SMTP id A5D6A9BE37; Thu, 15 Apr 2004 22:53:13 +0200 (CEST) Message-ID: <00f401c4232b$8700d0c0$7890a8c0@dyndns.org> From: "Cyrille Lefevre" To: Date: Thu, 15 Apr 2004 22:52:12 +0200 Organization: ACME MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2800.1409 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 X-Mailman-Approved-At: Fri, 16 Apr 2004 04:59:38 -0700 cc: "current @FreeBSD.org" Subject: bin/41071: make NO to NO_ transition patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2004 20:52:14 -0000 anyone interrested to validate and commit this PR ? it provide a patch set to change all NOFOO variables to NO_FOO. see thread "Standardized make options (or no doesn't always mean no)" restart on 24 July 2002 in -arch for details and comments. it depended on PR #41070 related to make enhancements and bug fixes which has been partly commited some days ago (.warning keyword). I'm using this patch for 2 years now w/o any problem except when upgrading perl from ports which should be fixed (no more NOPERL in /etc/make.conf). impacted files: around 285 Makefiles make.conf(5) share/examples/etc/make.conf share/mk/*.mk (well, only those w/ NOXXX vars :) new file: share/mk/bsd.var.mk sample outputs: $ make -v /usr/share/mk/bsd.var.mk NOPERL= "/usr/share/mk/bsd.var.mk", line 146: warning: NO_PERL should be defined in place of NOPERL -- using NO_PERL with the value of NOPERL and unsetting NOPERL. $ make -v /usr/share/mk/bsd.var.mk NOPERL= NO_PERL= "/usr/share/mk/bsd.var.mk", line 142: warning: both NO_PERL and NOPERL are defined with the same value -- using NO_PERL and unsetting NOPERL. $ make -v /usr/share/mk/bsd.var.mk NOPERL=yes NO_PERL=no "/usr/share/mk/bsd.var.mk", line 139: warning: both NO_PERL and NOPERL are defined with a different value -- using NO_PERL and unsetting NOPERL. $ make -v /usr/share/mk/bsd.var.mk NONO_PERL= "/usr/share/mk/bsd.var.mk", line 132: warning: NONO_PERL is defined -- unsetting NOPERL, NO_PERL and NONO_PERL. PS : for instance, NONOPERL isn't handled but could be easily added. Cyrille Lefevre. -- home: mailto:cyrille.lefevre@laposte.net