From owner-freebsd-doc@FreeBSD.ORG  Wed Dec 10 02:30:22 2003
Return-Path: <owner-freebsd-doc@FreeBSD.ORG>
Delivered-To: freebsd-doc@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7722016A4CE
	for <freebsd-doc@hub.freebsd.org>;
	Wed, 10 Dec 2003 02:30:22 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 363E743D1D
	for <freebsd-doc@hub.freebsd.org>;
	Wed, 10 Dec 2003 02:30:21 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hBAAUKFY001997
	for <freebsd-doc@freefall.freebsd.org>;
	Wed, 10 Dec 2003 02:30:20 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hBAAUKDb001996;
	Wed, 10 Dec 2003 02:30:20 -0800 (PST)
	(envelope-from gnats)
Date: Wed, 10 Dec 2003 02:30:20 -0800 (PST)
Message-Id: <200312101030.hBAAUKDb001996@freefall.freebsd.org>
To: freebsd-doc@FreeBSD.org
From: Lukas Ertl <l.ertl@univie.ac.at>
Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of
 arch handbook
X-BeenThere: freebsd-doc@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Lukas Ertl <l.ertl@univie.ac.at>
List-Id: Documentation project <freebsd-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-doc>
List-Post: <mailto:freebsd-doc@freebsd.org>
List-Help: <mailto:freebsd-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Dec 2003 10:30:22 -0000

The following reply was made to PR docs/60107; it has been noted by GNATS.

From: Lukas Ertl <l.ertl@univie.ac.at>
To: j.el-rayes@daemon.li
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of
 arch handbook
Date: Wed, 10 Dec 2003 11:21:44 +0100 (CET)

 On Wed, 10 Dec 2003, Josef El-Rayes wrote:
 
 > Lukas Ertl <l.ertl@univie.ac.at> wrote:
 > > +#include &lt;sys/param.h&gt;  /* defines used in kernel.h */
 > > -#include &lt;sys/param.h&gt;  /* defines used in kernel.h */
 >
 > hi lukas!
 >
 > it is a good idea to have a look at the diff-generated patch
 > before sending in, to avoid bogus lines like this.
 
 It is a good idea to actually understand what the patch does before
 calling it bogus.
 
 The original code had sys/param.h and sys/types.h included, which is a
 style(9) violation.  My patch removes one include and moves the other one
 further up.
 
 regards,
 le
 
 -- 
 Lukas Ertl                             eMail: l.ertl@univie.ac.at
 UNIX Systemadministrator               Tel.:  (+43 1) 4277-14073
 Vienna University Computer Center      Fax.:  (+43 1) 4277-9140
 University of Vienna                   http://mailbox.univie.ac.at/~le/