From owner-svn-src-all@FreeBSD.ORG Fri Jan 29 16:14:35 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DC3E3106566C; Fri, 29 Jan 2010 16:14:35 +0000 (UTC) (envelope-from marcel@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id CBAB78FC0A; Fri, 29 Jan 2010 16:14:35 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o0TGEZJW010663; Fri, 29 Jan 2010 16:14:35 GMT (envelope-from marcel@svn.freebsd.org) Received: (from marcel@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o0TGEZ7m010661; Fri, 29 Jan 2010 16:14:35 GMT (envelope-from marcel@svn.freebsd.org) Message-Id: <201001291614.o0TGEZ7m010661@svn.freebsd.org> From: Marcel Moolenaar Date: Fri, 29 Jan 2010 16:14:35 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r203171 - head/sys/arm/arm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2010 16:14:36 -0000 Author: marcel Date: Fri Jan 29 16:14:35 2010 New Revision: 203171 URL: http://svn.freebsd.org/changeset/base/203171 Log: When backtracing self, start with the current frame (i.e. the frame of db_trace_self()) and not the caller's frame. The use of builtin_frame_address(1) to get the caller's frame is not reliable and can cause panics. Modified: head/sys/arm/arm/db_trace.c Modified: head/sys/arm/arm/db_trace.c ============================================================================== --- head/sys/arm/arm/db_trace.c Fri Jan 29 15:58:12 2010 (r203170) +++ head/sys/arm/arm/db_trace.c Fri Jan 29 16:14:35 2010 (r203171) @@ -206,6 +206,6 @@ db_trace_self(void) { db_addr_t addr; - addr = (db_addr_t)__builtin_frame_address(1); + addr = (db_addr_t)__builtin_frame_address(0); db_stack_trace_cmd(addr, -1); }