From owner-cvs-ports@FreeBSD.ORG Sun Jan 15 07:03:44 2012 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 385081065675; Sun, 15 Jan 2012 07:03:44 +0000 (UTC) (envelope-from yarodin@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6420D8FC0C; Sun, 15 Jan 2012 07:03:43 +0000 (UTC) Received: by bke11 with SMTP id 11so510429bke.13 for ; Sat, 14 Jan 2012 23:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:x-priority:message-id:to:cc:subject:in-reply-to :references:mime-version:content-type; bh=/ohDi8hFADf49A8iyUZsWLOIVXjYVGxNd39ZV6Mv0Ic=; b=EJH/s/9DNluxQ1KwnCvO6QpkurMqU2OROi6Z5rE5ZPGjPbleI3OgeRBvWt+iYoBj+r o79KfyUhq19XXt6UjE3GwASSRDjlJbuNxMkHVIW+z6fX2EbF8FvEQyc8WbxSst8sTNzu nUSKLMO29EFpccmGEkAC6HyE+ZqjlTDCJ9cW0= Received: by 10.204.156.207 with SMTP id y15mr2825849bkw.93.1326609387504; Sat, 14 Jan 2012 22:36:27 -0800 (PST) Received: from [192.168.1.2] ([94.50.60.12]) by mx.google.com with ESMTPS id y22sm30227992bkf.4.2012.01.14.22.36.24 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 14 Jan 2012 22:36:26 -0800 (PST) Date: Sun, 15 Jan 2012 12:35:04 +0600 From: Yar X-Priority: 3 (Normal) Message-ID: <147869552.20120115123504@gmail.com> To: poyopoyo@puripuri.plala.or.jp In-Reply-To: <8662gfjd02.wl%poyopoyo@puripuri.plala.or.jp> References: <201201080930.q089UX6D091198@repoman.freebsd.org> <8662gfjd02.wl%poyopoyo@puripuri.plala.or.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----------11D1B60F1078BA4C3" Cc: Sunpoet Po-Chuan Hsieh , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/archivers/unrar Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2012 07:03:44 -0000 ------------11D1B60F1078BA4C3 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hello Poyopoyo, Saturday, January 14, 2012, 7:20:45, you wrote: > At Sun, 8 Jan 2012 09:30:33 +0000 (UTC), > Sunpoet Po-Chuan Hsieh wrote: >> @@ -24,6 +24,9 @@ MAKEFILE= makefile.unix >> PLIST_FILES= bin/unrar >> PORTDOCS= license.txt readme.txt >> >> +post-patch: >> + @${REINPLACE_CMD} -e '/^CXX/ s|^|#|' ${WRKSRC}/${MAKEFILE} >> + >> do-install: >> ${INSTALL_PROGRAM} ${WRKSRC}/unrar ${PREFIX}/bin >> .if !defined(NOPORTDOCS) > Hi, > Commenting CXX* out after patch phase breaks unrar-iconv since it > requires CXXFLAGS to be set in makefile.unix. ===>> Building for unrar-iconv-4.10,5 > c++ -O2 -pipe -march=native -fno-strict-aliasing > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DWITH_ICONV -DUNRAR -c rar.cpp > In file included from rar.hpp:5, > from rar.cpp:1: > os.hpp:197:19: error: iconv.h: No such file or directory > In file included from rar.hpp:76, > from rar.cpp:1: > global.hpp:19: error: 'iconv_t' does not name a type > global.hpp:20: error: 'iconv_t' does not name a type > gmake: *** [rar.o] Error 1 > *** Error code 1 > Here's a candidate: > - Comment CXX* out for only unrar not for unrar-iconv. I vote for it! \if !defined(USE_ICONV) at unrar Makefile\. It's more accuracy at my point of view. > - in unrar-iconv do the same thing with files/patch-iconv. BUT :) I attached tiny patch for unrar-iconv/Makefile with dirty workaround. -- Best regards, Yar mailto:yarodin@gmail.com ------------11D1B60F1078BA4C3 Content-Type: application/octet-stream; name="unrar-iconv_Makefile.patch" Content-transfer-encoding: base64 Content-Disposition: attachment; filename="unrar-iconv_Makefile.patch" LS0tIE1ha2VmaWxlLm9yaWcJMjAxMi0wMS0xNSAxMjoyMDoxNy4wMDAwMDAwMDAgKzA3MDAK KysrIE1ha2VmaWxlCTIwMTItMDEtMTUgMTI6MTk6NDQuMDAwMDAwMDAwICswNzAwCkBAIC0x Nyw2ICsxNyw5IEBACiAKIENPTkZMSUNUUz0JdW5yYXItWzAtOV0qIHpoLXVucmFyLVswLTld KgogCitwcmUtYnVpbGQ6CisJQCR7UkVJTlBMQUNFX0NNRH0gLWUgJy9eI0NYWEZMQUdTKz0v IHN8XiN8fCcgJHtXUktTUkN9LyR7TUFLRUZJTEV9CisKIHBvc3QtaW5zdGFsbDoKIAlAJHtF Q0hPX01TR30gIj09PT4gQWRkZWQgaWNvbnYgc3VwcG9ydCwgc2VlIG5ldyBzd2l0Y2hlczoi CiAJQCR7RUNIT19NU0d9ICIgICAgIGxhLCBsbCBhbmQgbG8gYXQgXCJ1bnJhciAtP1wiIgo= ------------11D1B60F1078BA4C3--