From owner-svn-src-head@FreeBSD.ORG Thu Jan 22 08:39:07 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CDDBF609; Thu, 22 Jan 2015 08:39:07 +0000 (UTC) Received: from mail.turbocat.net (mail.turbocat.net [IPv6:2a01:4f8:d16:4514::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 87899D8B; Thu, 22 Jan 2015 08:39:07 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id DACE51FE023; Thu, 22 Jan 2015 09:39:04 +0100 (CET) Message-ID: <54C0B75B.9070305@selasky.org> Date: Thu, 22 Jan 2015 09:39:55 +0100 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Konstantin Belousov Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54BDD9E1.6090505@selasky.org> <20150120075126.GA42409@kib.kiev.ua> <54BE0AAA.4050104@selasky.org> <20150120090057.GD42409@kib.kiev.ua> <54BE21F0.6010602@selasky.org> <7C692107-51CF-4DFA-BD6C-623D56893150@bsdimp.com> <54C0A352.8090701@selasky.org> <20150122081023.GT42409@kib.kiev.ua> In-Reply-To: <20150122081023.GT42409@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , Warner Losh X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 08:39:07 -0000 On 01/22/15 09:10, Konstantin Belousov wrote: > On Thu, Jan 22, 2015 at 08:14:26AM +0100, Hans Petter Selasky wrote: >> On 01/22/15 06:26, Warner Losh wrote: >> > >>>> The code simply needs an update. It is not broken in any ways - right? If it is not broken, fixing it is not that urgent. >>> >>> Radically changing the performance characteristics is breaking the code. Performance regression in the TCP stack is urgent to fix. > >> Not being able to enumerate what all the consumers are that use this and >> provide an analysis about why they aren?t important to fix is a bug in >> your process, and in your interaction with the project. We simply do not >> operate that way. > Right, I completely agree with this statement. > > >> Hi, >> >> My plan is to work out a patch for the TCP stack today, which only >> change the callout_init() call or its function. This should not need any >> particular review. I'll let adrian test and review, because I think he >> is closer to me timezone wise and you're standing on my head saying its >> urgent. If he is still not happy, I can back my change out. Else it >> remains in -current AS-IS. > TCP regresssion was noted, so it is brought in front. There is nothing > else which makes TCP issue different from other (hidden) issues. > > =========================== >> MFC to 10-stable I can delay for sure until >> all issues you report to me are fixed. > =========================== > > Sigh, you still do not understand. It is your duty to identify all pieces > which break after your change. After that, we can argue whether each of > them is critical or not to allow the migration. But this must have been > done before the KPI change hit the tree. > Hi, Are you saying that pieces of code that runs completely unlocked using "volatile" as only synchronization mechanism is better than what I would call a temporary and hopefully short TCP stack performance loss? I don't understand? How frequently do you reboot your boxes? Maybe one every day? And you don't care? --HPS