From owner-freebsd-arch@FreeBSD.ORG  Fri Dec  3 20:28:08 2004
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4E1FD16A4CE
	for <arch@freebsd.org>; Fri,  3 Dec 2004 20:28:08 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AA26943D41
	for <arch@freebsd.org>; Fri,  3 Dec 2004 20:28:07 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (harmony.village.org [10.0.0.6])
	by harmony.village.org (8.13.1/8.13.1) with ESMTP id iB3KPe4v007150;
	Fri, 3 Dec 2004 13:25:41 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Fri, 03 Dec 2004 13:26:50 -0700 (MST)
Message-Id: <20041203.132650.04772724.imp@bsdimp.com>
To: marcel@xcllnt.net
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20041203194201.GB16093@ns1.xcllnt.net>
References: <200412030813.iB38DA12044595@repoman.freebsd.org>
	<20041203.110520.54185564.imp@bsdimp.com>
	<20041203194201.GB16093@ns1.xcllnt.net>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: arch@freebsd.org
Subject: Re: cvs commit: src/sys/dev/pci pci.c
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Dec 2004 20:28:08 -0000

In message: <20041203194201.GB16093@ns1.xcllnt.net>
            Marcel Moolenaar <marcel@xcllnt.net> writes:
: On Fri, Dec 03, 2004 at 11:05:20AM -0700, M. Warner Losh wrote:
: > In message: <200412030813.iB38DA12044595@repoman.freebsd.org>
: >             Nate Lawson <njl@FreeBSD.org> writes:
: > : njl         2004-12-03 08:13:09 UTC
: > : 
: > :   FreeBSD src repository
: > : 
: > :   Modified files:
: > :     sys/dev/pci          pci.c 
: > :   Log:
: > :   Non-x86 platforms cannot use the ACPI includes.  This should be fixed but
: > :   for now, only include the headers for i386, amd64, or ia64.
: > :   
: > :   Pointed out by: grehan
: > 
: > We likely should have a sys/$MACHINE_ARCH/include/_config.h that has a
: > bunch of #defines that we can test instead of specific architecture
: > lists, don't you think?
: 
: A <machine/_config.h> doesn't give me warm fuzzies. Maybe we can
: rename <machine/pci_cfgreg.h> to <machine/pci.h> and give it some
: additional use (for this particular case of course).

There's a growing number of these sorts of things.  NetBSD has this
information in machine/types.h.  For example:

#include <mips/types.h>

#define __HAVE_GENERIC_SOFT_INTERRUPTS
#define __HAVE_DEVICE_REGISTER
#define __HAVE_NWSCONS

#define __HAVE_MIPS_MACHDEP_CACHE_CONFIG

I was thinking that we should start doing something similar...

Warner