From owner-svn-ports-head@FreeBSD.ORG  Sun Sep  1 13:07:19 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id BF7CF906;
 Sun,  1 Sep 2013 13:07:19 +0000 (UTC)
 (envelope-from sahil@tandon.net)
Received: from cricket.hamla.org (cricket.hamla.org [206.251.255.31])
 by mx1.freebsd.org (Postfix) with ESMTP id A4AC12A8B;
 Sun,  1 Sep 2013 13:07:19 +0000 (UTC)
Received: from jubz (cpe-68-174-190-55.nyc.res.rr.com [68.174.190.55])
 by cricket.hamla.org (Postfix) with ESMTPSA id 69FDB8A068;
 Sun,  1 Sep 2013 09:07:12 -0400 (EDT)
Date: Sun, 1 Sep 2013 09:07:10 -0400
From: Sahil Tandon <sahil@tandon.net>
To: Anton Berezin <tobez@FreeBSD.org>
Subject: Re: svn commit: r325805 - head/Mk
Message-ID: <20130901130709.GA55745@jubz>
References: <201308311322.r7VDM2wa076581@svn.freebsd.org>
 <20130831215840.GA13875@magnus>
 <20130901105928.GG26604@heechee.tobez.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130901105928.GG26604@heechee.tobez.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Virus-Scanned: clamav-milter 0.97.3 at cricket.hamla.org
X-Virus-Status: Clean
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org, Bryan Drewery <bdrewery@FreeBSD.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Sahil Tandon <sahil@tandon.net>
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Sep 2013 13:07:19 -0000

On Sun, 2013-09-01 at 12:59:28 +0200, Anton Berezin wrote:
[ .. ]
> >   => Attempting to fetch
> >   ftp://ftp.porcupine.org/mirrors/postfix-release/experimental/postfix-2.11-20130825.tar.gz
> >   postfix-2.11-20130825.tar.gz                  100% of 3866 kB  910
> >   kBps
> >   [: -eq: argument expected
> >   => Fetched file size mismatch (expected , actual 3959547)
> >   => Trying next site
> > 
> > This only happens if the distfile does not already exist (and therefore
> > needs to be fetched), and I 'make makesum'.  Apparently, CKSIZE is
> > undefined.  Notably, if I 'make fetch' first, and then 'make makesum',
> > there is no problem.
> 
> I see the same behavior.  So, updating ports is kinda broken at the moment.

Looking at this a bit more, and I believe it happens because the makesum
target calls the fetch target with DISABLE_SIZE=yes, and earlier in
bsd.port.mk, we have:

  .if !defined(DISABLE_SIZE)
  FETCH_BEFORE_ARGS+=     $${CKSIZE:+-S $$CKSIZE}
  .endif

Because CKSIZE is undefined, the following comparison inside the fetch
target does not work as intended:

  if [ $${actual_size} -eq $${CKSIZE} ]; then \

Hope this helps.

-- 
Sahil Tandon