From owner-p4-projects@FreeBSD.ORG Wed Apr 3 19:14:48 2013 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 929E74A6; Wed, 3 Apr 2013 19:14:48 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 525204A3; Wed, 3 Apr 2013 19:14:48 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) by mx1.freebsd.org (Postfix) with ESMTP id 3263F927; Wed, 3 Apr 2013 19:14:48 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 246FBB9A3; Wed, 3 Apr 2013 15:14:47 -0400 (EDT) From: John Baldwin To: Brooks Davis Subject: Re: PERFORCE change 227289 for review Date: Wed, 3 Apr 2013 15:12:44 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <201304012009.r31K9NA6027721@skunkworks.freebsd.org> In-Reply-To: <201304012009.r31K9NA6027721@skunkworks.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201304031512.44463.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Wed, 03 Apr 2013 15:14:47 -0400 (EDT) Cc: Perforce Change Reviews X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2013 19:14:48 -0000 On Monday, April 01, 2013 4:09:23 pm Brooks Davis wrote: > http://p4web.freebsd.org/@@227289?ac=10 > > Change 227289 by brooks@brooks_zenith on 2013/04/01 20:08:35 > > Record the interrupt-parent of devices that have one in > struct device. Use this to improve reporting of interrupt-parents > in two ways: > > Add an indication of the interrupt-parent when printing the > child's resources: > > altera_jtag_uart0: mem 0x900000007f000000-0x900000007f00003f irq 0 (beripic0) on simplebus0 > > Extend struct u_device and the hw.bus.devices sysctl used > by libdevinfo to include the device parent. This is done > in a fully foward and backward compatible manner. The > kernel can now return a partial structure when an old > libdevinfo requests a u_device that is shorter than the > current version. Each new field or set of fields in > u_device is indicated by a bit in the dv_fields entry. > > Use this new functionality to add a -i option to devinfo > that shows the device tree by interrupt-parent rather than > bus. Resources described as "Interrupt" are always shown > in -i mode Hmm, is this really generically useful? I would rather think that you might want to export more information about interrupt sources that maps IRQ cookies to (pic, pin) tuples or the like. This seems like a very platform-specific thing to be putting into 'struct device'. -- John Baldwin