From owner-freebsd-ports Wed Jun 25 08:42:10 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id IAA29116 for ports-outgoing; Wed, 25 Jun 1997 08:42:10 -0700 (PDT) Received: from smtp1.ts.kiev.ua (viking.ts.kiev.ua [193.124.229.195]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id IAA29106 for ; Wed, 25 Jun 1997 08:41:51 -0700 (PDT) Received: from aviion.ts.kiev.ua by smtp1.ts.kiev.ua with SMTP id SAA28127; (8.8.3/zah/2.1) Wed, 25 Jun 1997 18:17:47 +0300 (EET DST) Received: from nbki.ipri.kiev.ua by aviion.ts.kiev.ua with ESMTP id PAA13170; (8.6.11/zah/2.1) Wed, 25 Jun 1997 15:43:04 GMT Received: from cki.ipri.kiev.ua by nbki.ipri.kiev.ua with ESMTP id RAA11529; (8.6.9/zah/1.1) Wed, 25 Jun 1997 17:33:59 +0100 Received: from 194.44.146.14 (mac.ipri.kiev.ua [194.44.146.14]) by cki.ipri.kiev.ua (8.7.6/8.7.3) with SMTP id RAA00434; Wed, 25 Jun 1997 17:30:51 +0300 (EET DST) Message-ID: <33B11DD4.6F79@cki.ipri.kiev.ua> Date: Wed, 25 Jun 1997 16:31:59 +0300 From: Ruslan Shevchenko Reply-To: rssh@cki.ipri.kiev.ua Organization: IPRI X-Mailer: Mozilla 3.01Gold (Macintosh; I; 68K) MIME-Version: 1.0 To: itojun@itojun.org CC: ports@freebsd.org Subject: Re: about portlint References: <33B0D671.3A09@cki.ipri.kiev.ua> <13066.867248509@itojun.csl.sony.co.jp> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk itojun@itojun.org wrote: > > >> how's this? > >> ftp://ftp.foretune.co.jp/pub/tools/portlint/portlint.pl-1.14 > >1. As I can understand, you chack pathname in > > PATHSITES, PATHFILES. > >what if i have patch, living in directory > >ftp.x.y/pub/usr/X11R6/lib/patch-for-foo ? > >(of course, probability is low, but exists) > > I've added some rules to exclude URLs from the absolute > pathname check. > > >2. How about checkpathname in all files from > > scripts/* (--optional, with WARH) ? > > I'll try it, + pkg/REQ pkg/INSTALL pkg/DEINSTALL > > >No, it's I sorry. > > It is my port: pr-3758. > >You don't need to look at it, the matter, that the SR > >have own configure script, in which prefix must be parameter. > >then, in configure i seen the code in next style: > > case $prefix in) > > /opt) > > ..... > >So, i *must* to write an absolute pathname. > >So, I want future, such as: > >### ---portlint, do not look at next line--- ###. > >PREFIX=/usr/local > > like /*NOTREACHED*/ or /*ARGSUSED*/ in real lint? > mmm, that depends on how you interpret the warning from portlint. > > If you know what you are doing, I believe you can ignore what > portlint warns you in the above case. > portlint can never be a perfect parser for makefile/shell script/ > whatever... (of course I'm trying to, but I have to make a > compromise at some level) It can be very simple pattern-matching mechanism, I think, that some trivial, as #BEGIN portlint-ignore #END portlin ignore would be ok. > > anyway thanks for the comments, I'll try to update soon. > > itojun