From owner-p4-projects  Sat Sep  7 16:40:22 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 432CD37B409; Sat,  7 Sep 2002 16:40:13 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2776C37B405; Sat,  7 Sep 2002 16:40:12 -0700 (PDT)
Received: from sccrmhc01.attbi.com (sccrmhc01.attbi.com [204.127.202.61])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7A75443E65; Sat,  7 Sep 2002 16:40:11 -0700 (PDT)
	(envelope-from julian@elischer.org)
Received: from InterJet.elischer.org ([12.232.206.8])
          by sccrmhc01.attbi.com
          (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP
          id <20020907234010.EPMN9751.sccrmhc01.attbi.com@InterJet.elischer.org>;
          Sat, 7 Sep 2002 23:40:10 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id QAA48832;
	Sat, 7 Sep 2002 16:26:57 -0700 (PDT)
Date: Sat, 7 Sep 2002 16:26:56 -0700 (PDT)
From: Julian Elischer <julian@elischer.org>
To: Jonathan Mini <mini@FreeBSD.org>
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 17212 for review
In-Reply-To: <200209072319.g87NJum2099365@freefall.freebsd.org>
Message-ID: <Pine.BSF.4.21.0209071626450.47897-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

what's the backtrace?


On Sat, 7 Sep 2002, Jonathan Mini wrote:

> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=17212
> 
> Change 17212 by mini@mini_stylus on 2002/09/07 16:19:49
> 
> 	Hold Giant while we allocate a thread. Jeffr says we needn't
> 	hold Gian over any UMA operation, but I'm still getting
> 	'Giant not held' panics when we need to allocate a thread
> 	here.
> 
> Affected files ...
> 
> .. //depot/projects/kse/sys/kern/kern_thread.c#106 edit
> 
> Differences ...
> 
> ==== //depot/projects/kse/sys/kern/kern_thread.c#106 (text+ko) ====
> 
> @@ -621,8 +621,11 @@
>  	/*
>  	 * Ensure that we have a spare thread available.
>  	 */
> -	if (ke->ke_tdspare == NULL)
> +	if (ke->ke_tdspare == NULL) {
> +		mtx_lock(&Giant);
>  		ke->ke_tdspare = thread_alloc();
> +		mtx_unlock(&Giant);
> +	}
>  
>  	/*
>  	 * Bound threads need no additional work.
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message