From owner-p4-projects  Sat Sep  7 21:56: 0 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8846737B401; Sat,  7 Sep 2002 21:55:55 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 25D7237B400
	for <perforce@freebsd.org>; Sat,  7 Sep 2002 21:55:55 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DB59C43E65
	for <perforce@freebsd.org>; Sat,  7 Sep 2002 21:55:54 -0700 (PDT)
	(envelope-from mini@freebsd.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g884tsJU046828
	for <perforce@freebsd.org>; Sat, 7 Sep 2002 21:55:54 -0700 (PDT)
	(envelope-from mini@freebsd.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g884tstv046825
	for perforce@freebsd.org; Sat, 7 Sep 2002 21:55:54 -0700 (PDT)
Date: Sat, 7 Sep 2002 21:55:54 -0700 (PDT)
Message-Id: <200209080455.g884tstv046825@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to mini@freebsd.org using -f
From: Jonathan Mini <mini@FreeBSD.org>
Subject: PERFORCE change 17224 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=17224

Change 17224 by mini@mini_stylus on 2002/09/07 21:55:17

	Tighten our grab for Giant from around UMA to just around the
	vm object allocation.

Affected files ...

.. //depot/projects/kse/sys/kern/kern_thread.c#107 edit

Differences ...

==== //depot/projects/kse/sys/kern/kern_thread.c#107 (text+ko) ====

@@ -155,7 +155,9 @@
 	    ("size mismatch: %d != %d\n", size, (int)sizeof(struct thread)));
 
 	td = (struct thread *)mem;
+	mtx_lock(&Giant);
 	pmap_new_thread(td);
+	mtx_unlock(&Giant);
 	cpu_thread_setup(td);
 	cached_threads++;	/* XXXSMP */
 	allocated_threads++;	/* XXXSMP */
@@ -456,9 +458,7 @@
 		ke->ke_tdspare = NULL;
 	} else {
 		mtx_unlock_spin(&sched_lock);
-		mtx_lock(&Giant);
 		td2 = thread_alloc();
-		mtx_unlock(&Giant);
 		mtx_lock_spin(&sched_lock);
 	}
 	CTR3(KTR_PROC, "thread_schedule_upcall: thread %p (pid %d, %s)",

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message