From owner-freebsd-scsi Mon Nov 25 6: 5:54 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E35BC37B401 for ; Mon, 25 Nov 2002 06:05:53 -0800 (PST) Received: from comp.chem.msu.su (comp-ext.chem.msu.su [158.250.32.157]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB50A43E4A for ; Mon, 25 Nov 2002 06:05:52 -0800 (PST) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.12.3/8.12.3) with ESMTP id gAPE5p9K031658; Mon, 25 Nov 2002 17:05:51 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.12.3/8.12.3/Submit) id gAPE5hZx031650; Mon, 25 Nov 2002 17:05:43 +0300 (MSK) Date: Mon, 25 Nov 2002 17:05:43 +0300 From: Yar Tikhiy To: Bruce Evans Cc: Nate Lawson , freebsd-scsi@FreeBSD.ORG Subject: Re: {da,sa,...}open bug? Message-ID: <20021125170543.A30909@comp.chem.msu.su> References: <20021125134302.D14452@comp.chem.msu.su> <20021125230811.K56791-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20021125230811.K56791-100000@gamplex.bde.org>; from bde@zeta.org.au on Mon, Nov 25, 2002 at 11:28:31PM +1100 Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Mon, Nov 25, 2002 at 11:28:31PM +1100, Bruce Evans wrote: > On Mon, 25 Nov 2002, Yar Tikhiy wrote: > > > While preparing the fix, I noticed an additional couple of oddities. > > First, files under sys/cam/scsi are inconsistent as to the order of > > calling cam_periph_release() and cam_periph_unlock(): Some of them > > will call cam_periph_release() first, and the others will call it second. > > Then, there's a number of places in the code where cam_periph_unlock() > > won't be called before return on a cam_periph_acquire() error, though > > the "periph" has been locked. > > I'd like this fixed too. I still have some patches written about 4 > years ago for a couple of these reversals. I think things should be > unlocked or released in the reverse of the order in which they were > locked or acquired, if possible. I think so, too. If you feel it's OK to push this into 5.0-RELEASE, I'll submit a patch here for review. -- Yar To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message