From owner-svn-ports-all@FreeBSD.ORG  Thu Dec 26 05:13:43 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 36A1A483; Thu, 26 Dec 2013 05:13:43 +0000 (UTC)
Date: Thu, 26 Dec 2013 05:13:43 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Pawel Pekala <pawel@FreeBSD.org>
Subject: Re: svn commit: r337439 - head/www/cntlm
Message-ID: <20131226051343.GA69157@FreeBSD.org>
References: <201312251916.rBPJGnSw066524@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201312251916.rBPJGnSw066524@svn.freebsd.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Dec 2013 05:13:43 -0000

On Wed, Dec 25, 2013 at 07:16:49PM +0000, Pawel Pekala wrote:
> New Revision: 337439
> URL: http://svnweb.freebsd.org/changeset/ports/337439
> 
> Log:
>   Fix build on -current
>   
>   [...]
>  do-install:
> -	${INSTALL_PROGRAM} ${WRKSRC}/cntlm ${STAGEDIR}${PREFIX}/bin/
> -	${INSTALL_DATA} ${WRKSRC}/doc/cntlm.conf ${STAGEDIR}${PREFIX}/etc/cntlm.conf.sample
> -	${INSTALL_MAN} ${WRKSRC}/doc/cntlm.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
> +	(cd ${WRKSRC} && ${INSTALL_PROGRAM} cntlm \
> +		${STAGEDIR}${PREFIX}/bin)
> +	(cd ${WRKSRC}/doc && ${INSTALL_DATA} cntlm.conf.sample \
> +		${STAGEDIR}${PREFIX}/etc)
> +	(cd ${WRKSRC}/doc && ${INSTALL_MAN} cntlm.1 \
> +		${STAGEDIR}${MANPREFIX}/man/man1)

Pawel,

The last hunk has nothing to do with "fixing the build on current", it makes
the code harder to read (6 lines instead of three, line wrapping), and is a
gratuitous (and plain bad) change.

I appreciate Katobot's build fixing PR's and patches, but let's not take
them as perfect and use it in their entirety, esp. when they contradict our
normal practices and style.

./danfe