From owner-freebsd-hackers@FreeBSD.ORG Wed Nov 10 15:09:31 2010 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91E401065670; Wed, 10 Nov 2010 15:09:31 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout028.mac.com (asmtpout028.mac.com [17.148.16.103]) by mx1.freebsd.org (Postfix) with ESMTP id 768C38FC08; Wed, 10 Nov 2010 15:09:31 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=us-ascii Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp028.mac.com (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 64bit)) with ESMTPSA id <0LBO00ASUCRAOQ70@asmtp028.mac.com>; Wed, 10 Nov 2010 07:09:11 -0800 (PST) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=6.0.2-1004200000 definitions=main-1011100074 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.2.15,1.0.148,0.0.0000 definitions=2010-11-10_05:2010-11-10, 2010-11-10, 1970-01-01 signatures=0 From: Marcel Moolenaar In-reply-to: Date: Wed, 10 Nov 2010 07:09:10 -0800 Message-id: <899E1FB8-C763-4DBC-90FB-83D0725F757A@mac.com> References: <478E6244-00B4-4D96-93FE-CBD546C27A6E@mac.com> To: Garrett Cooper X-Mailer: Apple Mail (2.1081) Cc: hackers@freebsd.org Subject: Re: [PATCH] Simplify uart_bus_pci_probe X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 15:09:31 -0000 On Nov 10, 2010, at 12:44 AM, Garrett Cooper wrote: > On Tue, Nov 9, 2010 at 10:29 PM, Marcel Moolenaar wrote: >> >> On Nov 6, 2010, at 11:22 AM, Garrett Cooper wrote: >> >>> Some of the logic could have been simplified in the probe. The >>> proposed patch makes the detection process a tad bit more >>> straightforward. >>> Comments, review (and maybe a commit :P) are more than welcome :). >> >> The patch is logically wrong for non-ns8250 based UARTs. >> Leave the code as is. > > Hi Marcel, > Is the layout of the pci_ns8250_ids PCI ID table correct then, as > there are a large number of ns16550 chips and other non-ns8250 chips > in the table? ns16550 is a ns8250 class UART. They are in the same family. Non-ns8250 UARTs include Zilog Z8530, Siemens SAB 82532, Freescale's PowerQUICC SCC, and even SGI's firmware based serial console of you like. FYI, -- Marcel Moolenaar xcllnt@mac.com