From owner-svn-src-all@FreeBSD.ORG Fri Aug 30 13:48:06 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9A2CD90B; Fri, 30 Aug 2013 13:48:06 +0000 (UTC) (envelope-from hps@bitfrost.no) Received: from mta.bitpro.no (mta.bitpro.no [92.42.64.202]) by mx1.freebsd.org (Postfix) with ESMTP id 565022653; Fri, 30 Aug 2013 13:48:06 +0000 (UTC) Received: from mail.lockless.no (mail.lockless.no [46.29.221.38]) by mta.bitpro.no (Postfix) with ESMTP id 98AFD7A18D; Fri, 30 Aug 2013 15:48:05 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.lockless.no (Postfix) with ESMTP id B43CE8F5148; Fri, 30 Aug 2013 15:48:18 +0200 (CEST) X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at lockless.no Received: from mail.lockless.no ([127.0.0.1]) by localhost (mail.lockless.no [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gVU85LvlDC6f; Fri, 30 Aug 2013 15:48:17 +0200 (CEST) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) by mail.lockless.no (Postfix) with ESMTPSA id 4ACE48F5147; Fri, 30 Aug 2013 15:48:17 +0200 (CEST) Message-ID: <5220A2DD.5040803@bitfrost.no> Date: Fri, 30 Aug 2013 15:49:17 +0200 From: Hans Petter Selasky Organization: Bitfrost A/S User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130522 Thunderbird/17.0.6 MIME-Version: 1.0 To: Andriy Gapon Subject: Re: svn commit: r255067 - head/sys/kern References: <201308301039.r7UAduI1052038@svn.freebsd.org> <5220A027.8070604@FreeBSD.org> In-Reply-To: <5220A027.8070604@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Aug 2013 13:48:06 -0000 On 08/30/13 15:37, Andriy Gapon wrote: > on 30/08/2013 13:39 Hans Petter Selasky said the following: >> Author: hselasky >> Date: Fri Aug 30 10:39:56 2013 >> New Revision: 255067 >> URL: http://svnweb.freebsd.org/changeset/base/255067 >> >> Log: >> Simplify pause_sbt() logic. Don't call DELAY() if remainder is less >> than or equal to zero. > > Discussed with? > Reviewed by? > Tested by? > Hi, I've checked MAINTAINERS first. A patch was sent to the freebsd-current mailing list, See XHCI USB debugging thread. Could probably have been discussed a bit more. The cold case logic for pause() is mainly used by the USB code and was factored out from usb_pause_mtx() a long while ago by me. Do you see anything technically wrong about my patch? --HPS