From owner-freebsd-current@FreeBSD.ORG Fri Apr 16 09:05:24 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C068C16A4CE; Fri, 16 Apr 2004 09:05:24 -0700 (PDT) Received: from mailbox.univie.ac.at (mail.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id CED6143D54; Fri, 16 Apr 2004 09:05:23 -0700 (PDT) (envelope-from le@FreeBSD.org) Received: from wireless (adslle.cc.univie.ac.at [131.130.102.11]) i3GG58vZ1080940; Fri, 16 Apr 2004 18:05:14 +0200 Date: Fri, 16 Apr 2004 18:05:07 +0200 (CEST) From: Lukas Ertl To: "Daniel O'Connor" In-Reply-To: <200404161447.29595.doconnor@gsoft.com.au> Message-ID: <20040416180054.A664@korben> References: <200404161447.29595.doconnor@gsoft.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: mailbox 4246; Body=0 Fuz1=0 Fuz2=0 cc: freebsd-current@FreeBSD.org cc: obrien@FreeBSD.org Subject: Re: GDB broken? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Apr 2004 16:05:24 -0000 On Fri, 16 Apr 2004, Daniel O'Connor wrote: > Hi, > I was helping someone test patches in -current and got a crash dump, but GDB > doesn't like reading it.. Same symptoms here. I tracked down the particular commit that causes this: Revert the change, and everything should go fine. Alexander Kabaev has proposed a different fix, I don't know if this one works: --8<-- Index: i386-tdep.c =================================================================== RCS file: /home/ncvs/src/contrib/gdb/gdb/i386-tdep.c,v retrieving revision 1.3 diff -u -r1.3 i386-tdep.c --- i386-tdep.c 28 Jun 2002 00:14:01 -0000 1.3 +++ i386-tdep.c 1 Apr 2004 06:01:52 -0000 @@ -685,8 +685,8 @@ /* Return PC of first real instruction. */ -int -i386_skip_prologue (int pc) +CORE_ADDR +i386_skip_prologue (CORE_ADDR pc) { unsigned char op; int i; Index: config/i386/tm-i386.h =================================================================== RCS file: /home/ncvs/src/contrib/gdb/gdb/config/i386/tm-i386.h,v retrieving revision 1.1.1.3 diff -u -r1.1.1.3 tm-i386.h --- config/i386/tm-i386.h 27 Jun 2002 23:04:07 -0000 1.1.1.3 +++ config/i386/tm-i386.h 1 Apr 2004 05:58:35 -0000 @@ -61,7 +61,7 @@ #define SKIP_PROLOGUE(frompc) (i386_skip_prologue (frompc)) -extern int i386_skip_prologue (int); +extern CORE_ADDR i386_skip_prologue (CORE_ADDR); /* Immediately after a function call, return the saved pc. */ --8<-- cheers, le -- Lukas Ertl http://mailbox.univie.ac.at/~le/ le@FreeBSD.org http://people.freebsd.org/~le/