From owner-freebsd-stable@FreeBSD.ORG Mon Aug 3 15:33:18 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C3871065673 for ; Mon, 3 Aug 2009 15:33:18 +0000 (UTC) (envelope-from David.Boyd@insightbb.com) Received: from mxsf01.insightbb.com (mxsf01.insightbb.com [74.128.0.71]) by mx1.freebsd.org (Postfix) with ESMTP id E71B68FC1B for ; Mon, 3 Aug 2009 15:33:17 +0000 (UTC) (envelope-from David.Boyd@insightbb.com) X-IronPort-AV: E=Sophos;i="4.43,315,1246852800"; d="asc'?scan'208";a="711189668" Received: from unknown (HELO asav00.insightbb.com) ([172.31.249.123]) by mxsf01.insightbb.com with ESMTP; 03 Aug 2009 11:04:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap0EAHuZdkpKgYh2/2dsb2JhbACLDscoCYQPBYFK X-IronPort-AV: E=Sophos;i="4.43,315,1246852800"; d="asc'?scan'208";a="90239049" Received: from 74-129-136-118.dhcp.insightbb.com (HELO sneezy) ([74.129.136.118]) by asav00.insightbb.com with SMTP; 03 Aug 2009 11:04:31 -0400 From: "David Boyd" To: Date: Mon, 3 Aug 2009 11:04:31 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0102_01CA142A.2D81BE60" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 Importance: Normal Cc: freebsd-stable@freebsd.org Subject: FW: 8.0-BETA2 sysinstall ignoring setting of nonInteractive X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2009 15:33:18 -0000 This is a multi-part message in MIME format. ------=_NextPart_000_0102_01CA142A.2D81BE60 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Can someone "PLEASE" commit this fix. Daniel was kind enough to write it up, but it has not been committed as of 8/3/2009. Thanks. -----Original Message----- From: Daniel O'Connor [mailto:doconnor@gsoft.com.au] Sent: Tuesday, July 21, 2009 8:28 PM To: freebsd-current@freebsd.org Cc: David Boyd Subject: Re: 8.0-BETA2 sysinstall ignoring setting of nonInteractive On Wed, 22 Jul 2009, David Boyd wrote: > With 8.0-BETA(1/2) sysinstall ignores setting of nonInteractive > variable when using USB-based install. > > With or without nonInteractive sysinstall issues message "Using USB > device: da0a" and waits for confirmation. > > This breaks unattended installations using USB device. I think this would fix it, can you test it? Index: media.c =================================================================== --- media.c (revision 195813) +++ media.c (working copy) @@ -262,7 +262,8 @@ mediaDevice = devs[0]; if (mediaDevice) mediaDevice->private = NULL; - msgConfirm("Using USB device: %s", mediaDevice->name); + if (!variable_get(VAR_NONINTERACTIVE)) + msgConfirm("Using USB device: %s", mediaDevice->name); return (mediaDevice ? DITEM_LEAVE_MENU : DITEM_FAILURE); } -- Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C ------=_NextPart_000_0102_01CA142A.2D81BE60 Content-Type: application/pgp-signature; name="signature.asc" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iD8DBQBKZl0N5ZPcIHs/zowRAoLJAJ9g6jj7/mBUj4NR3SMfh+3MV1g3fACfVZme 1YXKwM71isOudr84BUtk698= =1V92 -----END PGP SIGNATURE----- ------=_NextPart_000_0102_01CA142A.2D81BE60--