From owner-svn-src-all@FreeBSD.ORG Sat Apr 19 13:47:33 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2A6FCDC6; Sat, 19 Apr 2014 13:47:33 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1747A147E; Sat, 19 Apr 2014 13:47:33 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s3JDlWd7067222; Sat, 19 Apr 2014 13:47:32 GMT (envelope-from jilles@svn.freebsd.org) Received: (from jilles@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s3JDlWQM067221; Sat, 19 Apr 2014 13:47:32 GMT (envelope-from jilles@svn.freebsd.org) Message-Id: <201404191347.s3JDlWQM067221@svn.freebsd.org> From: Jilles Tjoelker Date: Sat, 19 Apr 2014 13:47:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r264677 - head/usr.bin/login X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Apr 2014 13:47:33 -0000 Author: jilles Date: Sat Apr 19 13:47:32 2014 New Revision: 264677 URL: http://svnweb.freebsd.org/changeset/base/264677 Log: login: Remove broken dialup log message. For 10 years, the "DIALUP , " message has required having a hostname (-h) instead of not having a hostname; therefore, it is never logged. Given that dialup is obsolete and this has not been fixed, remove the log message. Note that LOGALL, which is defined by default, logs a message for all logins, including dialup logins. Modified: head/usr.bin/login/login.c Modified: head/usr.bin/login/login.c ============================================================================== --- head/usr.bin/login/login.c Sat Apr 19 12:38:01 2014 (r264676) +++ head/usr.bin/login/login.c Sat Apr 19 13:47:32 2014 (r264677) @@ -489,14 +489,6 @@ main(int argc, char *argv[]) if (errno != EROFS) syslog(LOG_ERR, "chown(%s): %m", ttyn); - /* - * Exclude cons/vt/ptys only, assume dialup otherwise - * TODO: Make dialup tty determination a library call - * for consistency (finger etc.) - */ - if (hflag && isdialuptty(tty)) - syslog(LOG_INFO, "DIALUP %s, %s", tty, pwd->pw_name); - #ifdef LOGALL /* * Syslog each successful login, so we don't have to watch