From owner-freebsd-bugs@FreeBSD.ORG  Sun Apr 20 03:53:16 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8B2F837B401; Sun, 20 Apr 2003 03:53:16 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B9F5A43FCB; Sun, 20 Apr 2003 03:53:14 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA30874;
	Sun, 20 Apr 2003 20:53:12 +1000
Date: Sun, 20 Apr 2003 20:53:11 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: David Schultz <das@freebsd.org>
In-Reply-To: <200304201000.h3KA0WYk023513@freefall.freebsd.org>
Message-ID: <20030420204940.N19972@gamplex.bde.org>
References: <200304201000.h3KA0WYk023513@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-bugs@freebsd.org
Subject: Re: bin/51151: du hardlinkmatching is slow - fix included
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Apr 2003 10:53:17 -0000

On Sun, 20 Apr 2003, David Schultz wrote:

>  On Sun, Apr 20, 2003, Peter van Dijk wrote:
>  > On Sun, Apr 20, 2003 at 01:27:24AM -0700, David Schultz wrote:
>
>  > > If you would like to revise this patch, I would be happy to help
>  > > you get it committed.  You might also want to take a look at
>  > > style(9).
>
>  At a glance, just the whitespace around = and ==.

Look more closely.  There are style bugs on at least 7 of the 12 lines
of the part of the patch that you quoted, and printf format errors on
machines where dev_t isn't compatible with u_int...

Bruce