From owner-freebsd-bugs@FreeBSD.ORG Wed Dec 24 23:26:22 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 14469ED1 for ; Wed, 24 Dec 2014 23:26:22 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EF32C332A for ; Wed, 24 Dec 2014 23:26:21 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sBONQLPT029299 for ; Wed, 24 Dec 2014 23:26:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 196259] The NFSv4 server can deadlock when vfs.nfsd.enable_locallocks!=0 Date: Wed, 24 Dec 2014 23:26:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Dec 2014 23:26:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196259 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress --- Comment #1 from Rick Macklem --- Loic Blot had a deadlock in the NFSv4 server when he had set vfs.nfsd.enable_locallocks to the non-default value of 1. This deadlock is caused by a LOR between the sleep lock used by the NFSv4 server (nfsrv_locklf()) and relocking of the file's vnode. I will be committing a patch to fix this LOR into head and MFCing it to stable/10 and stable/9. The deadlock is avoided by leaving vfs.nfsd.enable_locallocks=0, which should be fine for most NFSv4 server uses. (vfs.nfsd.enable_locallocks=1 makes the NFSv4 server do VOP_ADVLOCK() to acquire locks on the file, so that non-nfsd threads running in the NFSv4 server machine see the byte range locks set by NFSv4 clients that have mounted the file system. If only NFS clients needs to see the locks, the default setting is fine.) -- You are receiving this mail because: You are the assignee for the bug.