From owner-freebsd-hackers@FreeBSD.ORG Wed Nov 10 20:41:54 2010 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 185A6106566B for ; Wed, 10 Nov 2010 20:41:54 +0000 (UTC) (envelope-from uqs@spoerlein.net) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2001:470:9a47::1]) by mx1.freebsd.org (Postfix) with ESMTP id A41F28FC08 for ; Wed, 10 Nov 2010 20:41:53 +0000 (UTC) Received: from acme.spoerlein.net (localhost.spoerlein.net [IPv6:::1]) by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id oAAKfqdq087249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 10 Nov 2010 21:41:52 +0100 (CET) (envelope-from uqs@spoerlein.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net; s=dkim200908; t=1289421712; bh=xVl8tCxsXX+E/y09Z4Si+cgLw/8WG1o/zWiYiJhCQy8=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=EEWWuGjmqPMlKSmFvCukMRrtWOKvKmM299K3c4ZTJRcV4MWT6+mFeAsGZS5G1xuCA NruMJuzalgI7K2hA6kMMdAgZglnSsi1KhcLzYv2WqkE4G4prrr7yv95V3A0Yo42n2J WbSXW1uT59zm/y5te7vjuuAdz+XrxQCLJJENqcDM= Received: (from uqs@localhost) by acme.spoerlein.net (8.14.4/8.14.4/Submit) id oAAKfqGe087248 for hackers@freebsd.org; Wed, 10 Nov 2010 21:41:52 +0100 (CET) (envelope-from uqs@spoerlein.net) Date: Wed, 10 Nov 2010 21:41:52 +0100 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: hackers@freebsd.org Message-ID: <20101110204152.GF85693@acme.spoerlein.net> Mail-Followup-To: hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Subject: libkvm: consumers of kvm_getprocs for non-live kernels? X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 20:41:54 -0000 Hi, I have this cleanup of libkvm sitting in my tree and it needs a little bit of testing, especially the function kvm_proclist, which is only called from kvm_deadprocs which is only called from kvm_getprocs when kd is not ALIVE. The only consumer in our tree that I can make out is *probably* kgdb, as ps(1), top(1), w(1), pkill(1), fstat(1), systat(1), pmcstat(8) and bsnmpd don't really work on coredumps But, the kgdb file gnu/usr.bin/binutils/gdb/kvm-fbsd.c, where kvm_getprocs is probably called on a dead kernel is not even used during build! So I guess I'm staring at dead code here, any kvm people around that can clue me in? Thanks, Uli