From owner-freebsd-net@FreeBSD.ORG  Fri Mar 20 13:31:17 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 76E647BC
 for <freebsd-net@freebsd.org>; Fri, 20 Mar 2015 13:31:17 +0000 (UTC)
Received: from work.netasq.com (gwlille.netasq.com [91.212.116.1])
 by mx1.freebsd.org (Postfix) with ESMTP id 38AB7CBD
 for <freebsd-net@freebsd.org>; Fri, 20 Mar 2015 13:31:16 +0000 (UTC)
Received: from work.netasq.com (localhost.localdomain [127.0.0.1])
 by work.netasq.com (Postfix) with ESMTP id 1D9F82700781;
 Fri, 20 Mar 2015 14:31:09 +0100 (CET)
Received: from localhost (localhost.localdomain [127.0.0.1])
 by work.netasq.com (Postfix) with ESMTP id E9AF0270078F;
 Fri, 20 Mar 2015 14:31:08 +0100 (CET)
Received: from work.netasq.com ([127.0.0.1])
 by localhost (work.netasq.com [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id IJxJocpSbMNw; Fri, 20 Mar 2015 14:31:08 +0100 (CET)
Received: from work.netasq.com (localhost.localdomain [127.0.0.1])
 by work.netasq.com (Postfix) with ESMTP id AFDBC2700781;
 Fri, 20 Mar 2015 14:31:08 +0100 (CET)
Date: Fri, 20 Mar 2015 14:31:07 +0100 (CET)
From: Emeric POUPON <emeric.poupon@stormshield.eu>
To: Hans Petter Selasky <hps@selasky.org>
Message-ID: <2047974073.25663527.1426858267777.JavaMail.zimbra@stormshield.eu>
In-Reply-To: <550AC709.1050404@selasky.org>
References: <522774578.25519037.1426765109046.JavaMail.zimbra@stormshield.eu>
 <550AC709.1050404@selasky.org>
Subject: Re: Fragment questions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: Fragment questions
Thread-Index: OUhKPrNSVR/pF0IjNqFko5qpn37xjw==
Cc: freebsd-net <freebsd-net@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Mar 2015 13:31:17 -0000

Hello,

Yes indeed, it has already been fixed!
However, the second point seems to be still here...

Regards,

Emeric

----- Mail original -----
De: "Hans Petter Selasky" <hps@selasky.org>
=C3=80: "Emeric POUPON" <emeric.poupon@stormshield.eu>, "freebsd-net" <free=
bsd-net@freebsd.org>
Envoy=C3=A9: Jeudi 19 Mars 2015 13:54:33
Objet: Re: Fragment questions

On 03/19/15 12:38, Emeric POUPON wrote:
> Hello,
>
> I noticed two questionable things in the fragmentation code:
> - in ip_fragment, we do not copy the flowid from the original mbuf to the=
 fragmented mbuf. Therefore we may output very desynchronized fragments (fi=
rst fragment emitted far later the second fragment, etc.)
> - in the ip_newid macro, we do "htons(V_ip_id++))" if we do not use rando=
mized id. In multi core systems, we may emit successive packets with the sa=
me id.
>
> Both problems combined lead to bad packet reassembly on the remote host.
>
> What do you think?
>

Hi,

I think this issue is already fixed:

https://svnweb.freebsd.org/base/head/sys/netinet/ip_output.c?revision=3D278=
103&view=3Dmarkup

--HPS