From owner-p4-projects@FreeBSD.ORG Wed Aug 25 18:21:27 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id AA3A21065698; Wed, 25 Aug 2010 18:21:27 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C34610656AD for ; Wed, 25 Aug 2010 18:21:27 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id C93F98FC1D for ; Wed, 25 Aug 2010 18:21:26 +0000 (UTC) Received: by eyx24 with SMTP id 24so604781eyx.13 for ; Wed, 25 Aug 2010 11:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=TD8JYMSR1hW6RfdrU6Zhmv64nG6T/nlzhCM/82G+vHE=; b=Ce6gaJQjoz0TRh0agpGXvBrxoDq614DYAd/FXzc9DhDq8uIrKaKTEJ8+6F21878mNO gJLCz2fg8E4QVP8FTL8IErCsCFRE/7wpUlzYEaYnkOqnWiH+MV8PrwqVUOXh7/+42UXN ks8ukz+WRFkZ4a7nFzaYzBKjJEQZlef3+pSFQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Y0YSCsUBSvyCvxNUPEaDlBVKfyIGFITVUBDqiLMMZaDpKKw+xF6X1gakx3eWJ8SAHv OUfV4ppEfM10YXyq12hzP6aSbc3N7oSPE1mdsG29fsU/Fs+5NeMzWI4qMAdjnlIcjIlS Zo/xvFU51aGzbYuaCMbCpYn4sSH80S8GWSh58= MIME-Version: 1.0 Received: by 10.213.14.79 with SMTP id f15mr3415413eba.58.1282760485640; Wed, 25 Aug 2010 11:21:25 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.14.47.197 with HTTP; Wed, 25 Aug 2010 11:21:25 -0700 (PDT) In-Reply-To: <201008251649.o7PGnD8q074706@skunkworks.freebsd.org> References: <201008251649.o7PGnD8q074706@skunkworks.freebsd.org> Date: Wed, 25 Aug 2010 11:21:25 -0700 X-Google-Sender-Auth: Ftls0mmQFmP7wdihQt27FJya2QQ Message-ID: From: Garrett Cooper To: Hans Petter Selasky Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Perforce Change Reviews Subject: Re: PERFORCE change 182898 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2010 18:21:28 -0000 On Wed, Aug 25, 2010 at 9:49 AM, Hans Petter Selasky wrote: > http://p4web.freebsd.org/@@182898?ac=3D10 > > Change 182898 by hselasky@hselasky_laptop001 on 2010/08/25 16:49:00 > > =A0 =A0 =A0 =A0LibUSB: > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0- patch for GNU/kFreeBSD by David Moles > > =A0 =A0 =A0 =A0PR: =A0 =A0 =A0 =A0 =A0 =A0 http://bugs.debian.org/cgi-bin= /bugreport.cgi?bug=3D594330 > =A0 =A0 =A0 =A0Reviewed by: =A0 =A0hselasky @ > > Affected files ... > > .. //depot/projects/usb/src/lib/libusb/libusb20.c#19 edit > > Differences ... > > =3D=3D=3D=3D //depot/projects/usb/src/lib/libusb/libusb20.c#19 (text+ko) = =3D=3D=3D=3D > > @@ -1182,7 +1182,7 @@ > =A0{ > =A0 =A0 =A0 =A0struct libusb20_backend *pbe; > > -#ifdef __FreeBSD__ > +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > =A0 =A0 =A0 =A0pbe =3D libusb20_be_alloc(&libusb20_ugen20_backend); > =A0#else > =A0 =A0 =A0 =A0pbe =3D NULL; Crazy question... if GNU/kFreeBSD is going to be rebranding the kernel as __FreeBSD_kernel__, what about the rest of the references that are guarded by __FreeBSD__ ? Thanks, -Garrett