From owner-freebsd-rc@FreeBSD.ORG Wed Jan 11 19:32:32 2006 Return-Path: X-Original-To: freebsd-rc@freebsd.org Delivered-To: freebsd-rc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D63616A41F for ; Wed, 11 Jan 2006 19:32:32 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from dbmail-mx3.orcon.co.nz (loadbalancer1.orcon.net.nz [219.88.242.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3D9243D45 for ; Wed, 11 Jan 2006 19:32:31 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from heff.fud.org.nz (60-234-149-201.bitstream.orcon.net.nz [60.234.149.201]) by dbmail-mx3.orcon.co.nz (8.13.2/8.13.2/Debian-1) with ESMTP id k0BJYMcX017000; Thu, 12 Jan 2006 08:34:22 +1300 Received: by heff.fud.org.nz (Postfix, from userid 1001) id A00D72843B; Thu, 12 Jan 2006 08:32:40 +1300 (NZDT) Date: Thu, 12 Jan 2006 08:32:40 +1300 From: Andrew Thompson To: Florent Thoumie Message-ID: <20060111193240.GB2332@heff.fud.org.nz> References: <20060111191825.GA2332@heff.fud.org.nz> <200601112029.21661.flz@xbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601112029.21661.flz@xbsd.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: ClamAV 0.87.1/1238/Wed Jan 11 23:19:06 2006 on dbmail-mx3.orcon.co.nz X-Virus-Status: Clean Cc: freebsd-rc@freebsd.org Subject: Re: review of rc.d/autobridge X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2006 19:32:32 -0000 On Wed, Jan 11, 2006 at 08:29:09PM +0100, Florent Thoumie wrote: > On Wednesday 11 January 2006 20:18, Andrew Thompson wrote: > > Hi, > > > > > > I have a patch here that adds rc.d/autobridge. This is aimed towards > > apps like qemu or vmware that open a tap interface and need it bridged > > with the network adapter, the user can set up a glob for interfaces to > > be automatically added (eg tap*). > > > > Can I get the etc/* and rc.conf.5 changes reviewed for scripting style > > and general faux pas. > > Haven't read carefully enough to comment, but why autobridge > instead of bridge ? > It seemed to describe the functionality, but its just a name and bridge would be fine by me. Andrew