From owner-freebsd-net@FreeBSD.ORG Fri May 28 14:35:48 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3488116A4CE; Fri, 28 May 2004 14:35:48 -0700 (PDT) Received: from rwcrmhc12.comcast.net (rwcrmhc12.comcast.net [216.148.227.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 69E5C43D41; Fri, 28 May 2004 14:35:47 -0700 (PDT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc12) with ESMTP id <20040528213538014007qs71e>; Fri, 28 May 2004 21:35:38 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id OAA85089; Fri, 28 May 2004 14:35:36 -0700 (PDT) Date: Fri, 28 May 2004 14:35:35 -0700 (PDT) From: Julian Elischer To: Gleb Smirnoff In-Reply-To: <20040528100914.GA43187@cell.sick.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-net@freebsd.org cc: Harti Brandt Subject: Re: shutdown node VS disconnect all hooks X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2004 21:35:48 -0000 there are some more nodes in the tree that are not in the netgraph directory. On Fri, 28 May 2004, Gleb Smirnoff wrote: > On Fri, May 28, 2004 at 01:31:09AM -0700, Julian Elischer wrote: > J> > JE>> If you do that, I suppose you need to edit all the nodes, right?. In that > J> > JE>> case could you please convert the initialisation of the typestructs > J> > JE>> to use C99 sparse initialisation? In that case future changes will be a good > J> > JE>> deal easier. > J> > JE> > J> > JE>actually I don't know if you do need to edit the nodes > J> > JE>types.. At one time it was true that unassigned elements on > J> > JE>the end will be NULL. > J> > > J> > Sure they will, but this will confuse the next one who is adding > J> > a new operation. I was just thinking: 'In the case that Gleb has nothing > J> > else to do he could as well just take the chance...' :-) > J> > J> He seems to have taken the bait > J> (heh heh) > J> > J> It'd be best to make the change to sparse initialisers a separate patch > J> that I cold commit separatly, > J> so reduce teh size of the functionality change patch. > J> > J> (or harti could commit it.., or ruslan) > > Agreed. I make a series of patches then :) > > Here is the first one - convert all ng_type initializers to C99 sparse type. > > AFAIK, we also have two netgraph ports. Adding of preshutdown method will break > them. I'll fix ng_netflow port, and notify maintainer of ng_daphne. > > -- > Totus tuus, Glebius. > GLEBIUS-RIPN GLEB-RIPE > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >