From owner-svn-ports-head@FreeBSD.ORG Sun Sep 1 13:23:26 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 11F6DD00 for ; Sun, 1 Sep 2013 13:23:26 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CEE6D2B35 for ; Sun, 1 Sep 2013 13:23:25 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r81DNPDF038936 for ; Sun, 1 Sep 2013 13:23:25 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r81DNPnO038929 for svn-ports-head@freebsd.org; Sun, 1 Sep 2013 13:23:25 GMT (envelope-from bdrewery) Received: (qmail 33387 invoked from network); 1 Sep 2013 08:23:23 -0500 Received: from unknown (HELO ?10.52.15.77?) (freebsd@shatow.net@198.228.235.142) by sweb.xzibition.com with ESMTPA; 1 Sep 2013 08:23:23 -0500 References: <201308311322.r7VDM2wa076581@svn.freebsd.org> <20130831215840.GA13875@magnus> <20130901105928.GG26604@heechee.tobez.org> <20130901130709.GA55745@jubz> Mime-Version: 1.0 (1.0) In-Reply-To: <20130901130709.GA55745@jubz> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: X-Mailer: iPhone Mail (10B329) From: Bryan Drewery Subject: Re: svn commit: r325805 - head/Mk Date: Sun, 1 Sep 2013 08:23:19 -0500 To: Sahil Tandon Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Anton Berezin , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2013 13:23:26 -0000 Looking now Sent from my iPhone On Sep 1, 2013, at 8:07, Sahil Tandon wrote: > On Sun, 2013-09-01 at 12:59:28 +0200, Anton Berezin wrote: > [ .. ] >>> =3D> Attempting to fetch >>> ftp://ftp.porcupine.org/mirrors/postfix-release/experimental/postfix-2.= 11-20130825.tar.gz >>> postfix-2.11-20130825.tar.gz 100% of 3866 kB 910 >>> kBps >>> [: -eq: argument expected >>> =3D> Fetched file size mismatch (expected , actual 3959547) >>> =3D> Trying next site >>>=20 >>> This only happens if the distfile does not already exist (and therefore >>> needs to be fetched), and I 'make makesum'. Apparently, CKSIZE is >>> undefined. Notably, if I 'make fetch' first, and then 'make makesum', >>> there is no problem. >>=20 >> I see the same behavior. So, updating ports is kinda broken at the momen= t. >=20 > Looking at this a bit more, and I believe it happens because the makesum > target calls the fetch target with DISABLE_SIZE=3Dyes, and earlier in > bsd.port.mk, we have: >=20 > .if !defined(DISABLE_SIZE) > FETCH_BEFORE_ARGS+=3D $${CKSIZE:+-S $$CKSIZE} > .endif >=20 > Because CKSIZE is undefined, the following comparison inside the fetch > target does not work as intended: >=20 > if [ $${actual_size} -eq $${CKSIZE} ]; then \ >=20 > Hope this helps. >=20 > --=20 > Sahil Tandon