From owner-svn-ports-head@FreeBSD.ORG  Thu Jun 18 01:14:11 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E891C93A;
 Thu, 18 Jun 2015 01:14:11 +0000 (UTC)
 (envelope-from so14k@valentine.liquidneon.com)
Received: from valentine.liquidneon.com (cl-1479.chi-02.us.sixxs.net
 [IPv6:2001:4978:f:5c6::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "valentine.liquidneon.com",
 Issuer "Gandi Standard SSL CA 2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id BB74828C;
 Thu, 18 Jun 2015 01:14:11 +0000 (UTC)
 (envelope-from so14k@valentine.liquidneon.com)
Received: by valentine.liquidneon.com (Postfix, from userid 1018)
 id 7F5838FFB9; Wed, 17 Jun 2015 19:14:08 -0600 (MDT)
Date: Wed, 17 Jun 2015 19:14:08 -0600
From: Brad Davis <brd@FreeBSD.org>
To: Steve Wills <swills@FreeBSD.org>
Cc: Adam Weinberger <adamw@adamw.org>, Brad Davis <brd@FreeBSD.org>,
 ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r389861 - in head/devel: cmake cmake-gui cmake-modules
Message-ID: <20150618011408.GC94853@valentine.liquidneon.com>
References: <201506162025.t5GKP6lx080770@svn.freebsd.org>
 <AD97DB22-EE1C-4779-A29F-EAEDA09E1E73@adamw.org>
 <20150617165030.GA48147@mouf.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150617165030.GA48147@mouf.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2015 01:14:12 -0000

On Wed, Jun 17, 2015 at 04:50:31PM +0000, Steve Wills wrote:
> On Wed, Jun 17, 2015 at 09:39:11AM -0600, Adam Weinberger wrote:
> > > On 16 Jun, 2015, at 14:25, Brad Davis <brd@FreeBSD.org> wrote:
> > > 
> > > Author: brd
> > > Date: Tue Jun 16 20:25:05 2015
> > > New Revision: 389861
> > > URL: https://svnweb.freebsd.org/changeset/ports/389861
> > > 
> > > Log:
> > >  Update devel/cmake, devel/cmake-gui and devel/cmake-modules to 3.2.3.
> > > 
> > > Modified: head/devel/cmake/Makefile
> > > ==============================================================================
> > > 
> > > LIB_DEPENDS=	libcurl.so:${PORTSDIR}/ftp/curl \
> > > -		libexpat.so:${PORTSDIR}/textproc/expat2
> > > +		libexpat.so:${PORTSDIR}/textproc/expat2 \
> > > +		libjsoncpp.so:${PORTSDIR}/devel/jsoncpp
> > 
> > Does this port really need to depend on libjsoncpp? The version bundled with cmake works just fine (--no-system-jsoncpp).
> > 
> > The only benefit to making everybody install jsoncpp (and scons) would be if the jsoncpp port is updated more often than the cmake port. But the jsoncpp port hasn't had an update since the day it was added 16 months ago.
> > 
> > Can you please consider dropping the libjsoncpp dependency and just adding --no-system-jsoncpp to CONFIGURE_ARGS?
> > 
> 
> In general, it is better to not used bundled libs where possible. Let's update
> the devel/jsoncpp port.

I have a PR I need to commit for that.. :)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200648

I don't care which we do.. If someone has a better reason..


Regards,
Brad Davis